Skip to content

Commit

Permalink
JSON wizards: Print parsing issues only with -customwizard-verbose
Browse files Browse the repository at this point in the history
Some wizards will miss required components when corresponding plugins
are disabled. That is fine, and not an error per se. When actually
developing a wizard, these kind of errors should of course be posted,
but that is what -customwizard-verbose is for.

Fixes: QTCREATORBUG-28502
Change-Id: I3647d37ef7ca4dace7592c5443bdd13720290016
Reviewed-by: Christian Stenger <[email protected]>
  • Loading branch information
e4z9 committed Nov 25, 2022
1 parent c210ffb commit e24ad7a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/plugins/projectexplorer/jsonwizard/jsonwizardfactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,8 @@ JsonWizardFactory *JsonWizardFactory::createWizardFactory(const QVariantMap &dat
if (!factory->initialize(data, baseDir, errorMessage)) {
delete factory;
factory = nullptr;
Core::MessageManager::writeDisrupting(*errorMessage);
if (verbose())
Core::MessageManager::writeDisrupting(*errorMessage);
}
return factory;
}
Expand Down

0 comments on commit e24ad7a

Please sign in to comment.