Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing index.html #111

Closed
wants to merge 1 commit into from
Closed

Fix missing index.html #111

wants to merge 1 commit into from

Conversation

ludovicm67
Copy link
Member

@ludovicm67 ludovicm67 commented Jun 25, 2024

This is still not 100% working as it should.
Contributions are welcome!

Running npm run serve works well.
The thing, is that the index.html file was not generated anymore in the dist directory.

I've done something which is still WIP in this PR ; if someone has a better way to fix this or want to take over this, please do!

To try the built version:

rm -r dist # to make sure to start from a clean base
npm run build
npx serve dist

It is important that the dist directory contains the following files:

  • spex.js
  • spex.umd.cjs
  • style.css

And to fix the issue we have, it should also contain:

  • index.html
  • favicon.ico

and any relevant files.

Verified

This commit was signed with the committer’s verified signature.
ludovicm67 Ludovic Muller
@ludovicm67 ludovicm67 requested a review from tpluscode June 25, 2024 05:50
Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: 03c71de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ludovicm67
Copy link
Member Author

Closing this in favor of #112.

@ludovicm67 ludovicm67 closed this Jun 25, 2024
@ludovicm67 ludovicm67 deleted the fix-index branch June 25, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant