Skip to content

Commit

Permalink
PLAY_TUNE_V2 SUPPORTED_TUNES - WIP (mavlink#1258)
Browse files Browse the repository at this point in the history
Changed supported formats to 32 bit- bitmask. Similar memory efficiency and much easier to process.
  • Loading branch information
hamishwillee authored Oct 29, 2019
1 parent ab5bbb7 commit 62d63da
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions message_definitions/v1.0/common.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3804,10 +3804,10 @@
</enum>
<enum name="TUNE_FORMAT">
<description>Tune formats (used for vehicle buzzer/tone generation).</description>
<entry value="0" name="TUNE_FORMAT_QBASIC1_1">
<entry value="1" name="TUNE_FORMAT_QBASIC1_1">
<description>Format is QBasic 1.1 Play: https://www.qbasic.net/en/reference/qb11/Statement/PLAY-006.htm.</description>
</entry>
<entry value="1" name="TUNE_FORMAT_MML_MODERN">
<entry value="2" name="TUNE_FORMAT_MML_MODERN">
<description>Format is Modern Music Markup Language (MML): https://en.wikipedia.org/wiki/Music_Macro_Language#Modern_MML.</description>
</entry>
</enum>
Expand Down Expand Up @@ -5853,17 +5853,21 @@
<field type="uint32_t[6]" name="link_rx_max" units="KiB/s">Network capacity to the component system. A value of UINT32_MAX implies the field is unused.</field>
</message>
<message id="400" name="PLAY_TUNE_V2">
<description>Play vehicle tone/tune (buzzer). Default format is QBasic 1.1. Supersedes message PLAY_TUNE.</description>
<wip/>
<!-- This message is work-in-progress and it can therefore change. It should NOT be used in stable production environments. -->
<description>Play vehicle tone/tune (buzzer). Supersedes message PLAY_TUNE.</description>
<field type="uint8_t" name="target_system">System ID</field>
<field type="uint8_t" name="target_component">Component ID</field>
<field type="uint8_t" name="format" enum="TUNE_FORMAT">Tune format</field>
<field type="char[252]" name="tune">Tune definition</field>
<field type="uint32_t" name="format" enum="TUNE_FORMAT">Tune format</field>
<field type="char[252]" name="tune">Tune definition as a NULL-terminated string.</field>
</message>
<message id="401" name="SUPPORTED_TUNES">
<wip/>
<!-- This message is work-in-progress and it can therefore change. It should NOT be used in stable production environments. -->
<description>Tune formats supported by vehicle. This should be emitted as response to MAV_CMD_REQUEST_MESSAGE.</description>
<field type="uint8_t" name="target_system">System ID</field>
<field type="uint8_t" name="target_component">Component ID</field>
<field type="uint8_t[200]" name="format" enum="TUNE_FORMAT">Array of supported tune formats</field>
<field type="uint32_t" name="format" enum="TUNE_FORMAT" display="bitmask">Bitfield of supported tune formats.</field>
</message>
<!-- Rover specific messages -->
<message id="9000" name="WHEEL_DISTANCE">
Expand Down

0 comments on commit 62d63da

Please sign in to comment.