forked from google/starlark-go
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
starlark/profile: use real time (not monotonic) clock for Profile.time (
google#187) Also, add integration test of profiler and 'go tool pprof'. Fixes google#186
- Loading branch information
Showing
2 changed files
with
98 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| // Copyright 2019 The Bazel Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style | ||
| // license that can be found in the LICENSE file. | ||
|
|
||
| package starlark_test | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "fmt" | ||
| "io/ioutil" | ||
| "os" | ||
| "os/exec" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "go.starlark.net/starlark" | ||
| ) | ||
|
|
||
| // TestProfile is a simple integration test that the profiler | ||
| // emits minimally plausible pprof-compatible output. | ||
| func TestProfile(t *testing.T) { | ||
| prof, err := ioutil.TempFile("", "profile_test") | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| defer prof.Close() | ||
| defer os.Remove(prof.Name()) | ||
| if err := starlark.StartProfile(prof); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
|
|
||
| const src = ` | ||
| def fibonacci(n): | ||
| res = list(range(n)) | ||
| for i in res[2:]: | ||
| res[i] = res[i-2] + res[i-1] | ||
| return res | ||
| fibonacci(100000) | ||
| ` | ||
|
|
||
| thread := new(starlark.Thread) | ||
| if _, err := starlark.ExecFile(thread, "foo.star", src, nil); err != nil { | ||
| _ = starlark.StopProfile() | ||
| t.Fatal(err) | ||
| } | ||
| if err := starlark.StopProfile(); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| prof.Sync() | ||
| cmd := exec.Command("go", "tool", "pprof", "-top", prof.Name()) | ||
| cmd.Stderr = new(bytes.Buffer) | ||
| cmd.Stdout = new(bytes.Buffer) | ||
| if err := cmd.Run(); err != nil { | ||
| t.Fatalf("pprof failed: %v; output=<<%s>>", err, cmd.Stderr) | ||
| } | ||
|
|
||
| // Typical output (may vary by go release): | ||
| // | ||
| // Type: wall | ||
| // Time: Apr 4, 2019 at 11:10am (EDT) | ||
| // Duration: 251.62ms, Total samples = 250ms (99.36%) | ||
| // Showing nodes accounting for 250ms, 100% of 250ms total | ||
| // flat flat% sum% cum cum% | ||
| // 320ms 100% 100% 320ms 100% fibonacci | ||
| // 0 0% 100% 320ms 100% foo.star | ||
| // | ||
| // We'll assert a few key substrings are present. | ||
| got := fmt.Sprint(cmd.Stdout) | ||
| for _, want := range []string{ | ||
| "flat%", | ||
| "fibonacci", | ||
| "foo.star", | ||
| } { | ||
| if !strings.Contains(got, want) { | ||
| t.Errorf("output did not contain %q", want) | ||
| } | ||
| } | ||
| if t.Failed() { | ||
| t.Logf("stderr=%v", cmd.Stderr) | ||
| t.Logf("stdout=%v", cmd.Stdout) | ||
| } | ||
| } |