Skip to content

Commit

Permalink
Address a FIXME.
Browse files Browse the repository at this point in the history
I believe the issue documented in the FIXME was a problem with some
older stdlib implementation/compiler versions. Drop it since it seems to
work fine now.
  • Loading branch information
bbannier committed Jan 10, 2025
1 parent 7daf250 commit 3b677c1
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions hilti/toolchain/src/base/util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ std::vector<std::string> util::split(std::string s, const std::string& delim) {

l.push_back(s.substr(0, p));

// FIXME: Don't understand why directly assigning to s doesn't work.
std::string t = s.substr(p + delim.size(), std::string::npos);
s = std::move(t);
s = s.substr(p + delim.size(), std::string::npos);
}

l.push_back(s);
Expand Down

0 comments on commit 3b677c1

Please sign in to comment.