Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggressively implement rule of 5 #1621

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
+191 −4
Draft

Aggressively implement rule of 5 #1621

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
36c9303
Enable clang-tidy rule to identify rule of 5 violations.
bbannier Dec 15, 2023
326223c
Fix rule of 5 violations in C++ unit tests.
bbannier Dec 15, 2023
d216104
Fix rule of 5 violations in compiler infrastructure.
bbannier Dec 15, 2023
0af5252
Fix rule of 5 violations for runtime exceptions.
bbannier Dec 15, 2023
ac72d53
Fix rule of 5 violations in `FiberContext`.
bbannier Dec 15, 2023
a672b15
Fix rule of 5 violations in `StackBuffer`.
bbannier Dec 15, 2023
c146604
Fix rule of 5 violations for fiber callbacks.
bbannier Dec 15, 2023
0c56e17
Fix rule of 5 violations for runtime ranges.
bbannier Dec 15, 2023
3ba907b
Fix rule of 5 violations for `Bytes`.
bbannier Dec 15, 2023
e8eefea
Fix rule of 5 violations for `StrongReference`.
bbannier Dec 15, 2023
8b82028
Fix rule of 5 violations for `Chain`.
bbannier Dec 15, 2023
46d5edb
Fix rule of 5 violations for `Stream`'s `SafeConstIterator`.
bbannier Dec 15, 2023
be53405
Fix rule of 5 violations for stream `View`.
bbannier Dec 15, 2023
6f1a76d
Fix rule of 5 violations for runtime regexp's `Pimpl`.
bbannier Dec 15, 2023
c059317
Fix rule of 5 violations for runtime filters.
bbannier Dec 15, 2023
37dc95e
Fix rule of 5 violations for `ParseError`.
bbannier Dec 15, 2023
6762dde
Fix rule of 5 violations for `Backtrack`.
bbannier Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix rule of 5 violations for stream View.
  • Loading branch information
@bbannier
bbannier committed Dec 19, 2023
commit be53405ae64a5bfd76b34f1071c12bc7cd94e38f
2 changes: 2 additions & 0 deletions hilti/runtime/include/types/stream.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,6 +1020,8 @@ class View final {
/** Constructor. */
View() = default;

~View() = default;

View(const View&) = default;
View(View&&) = default;

Expand Down