-
Notifications
You must be signed in to change notification settings - Fork 44
ci: fix space issues in docker #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
e642844
to
ecd0772
Compare
5e11d41
to
7360534
Compare
@pillo79 will clean up the commits later, but I have borrowed a few stuff from the arduino fork here, while also makig sure it still works with the way this repo is... hope to get your reviews! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor remarks!
.github/workflows/build.yml
Outdated
NEEDED_HALS=$(grep 'build.zephyr_hals=' $MODULE_PATH/boards.txt | cut -d '=' -f 2 | xargs -n 1 echo | sort -u) | ||
HAL_FILTER="-hal_.*" | ||
for hal in $NEEDED_HALS; do | ||
HAL_FILTER="$HAL_FILTER,+$hal" | ||
done | ||
echo "HAL_FILTER=$HAL_FILTER" | tee -a $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this depends on boards.txt
, which is Arduino packaging stuff. For the module test I think it would be better to hardcode the minimal list of HALs you need for the tests below (or just download everything, this is just a CI time saver 🙂).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pillo79 thanks for the review. Yes I will remove this chunk for now, I don't think minimal HAL is required since I mostly commented out the filter part and it is working fine without it too.
Let's add it back later if we feel like we're running out of space again. How does that sound?
7360534
to
0e510a8
Compare
Take inspiration from the Arduino's fork [1] to improve the CI for building and testing samples in the project by using the ci-base zephyr image to save on size. Use the new $MODULE_PATH to specify paths in the setup stages. [1] https://github.com/arduino/ArduinoCore-zephyr/blob/main/.github/workflows/build.yml Signed-off-by: Dhruva Gole <[email protected]>
0e510a8
to
f3ce0c6
Compare
github actions keep failing due to errors like these:
failed to register layer: write /opt/toolchains/zephyr-sdk-0.17.4/xtensa-nxp_rt700_hifi4_zephyr-elf/libexec/gcc/xtensa-nxp_rt700_hifi4_zephyr-elf/12.2.0/cc1: no space left on device
Error: Docker pull failed with exit code 1
Fix this by freeing up disk space on the runner before the job runs.