Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: add CONFIG_FILE_SYSTEM_LIB_LINK option #75752

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

JordanYates
Copy link
Collaborator

Add an option that links in the underlying file system libraries as usual, but doesn't compile in the Zephyr file system abstraction layer.

This can be useful to avoid linking in the entire filesystem implementation through the fs_file_system_t API struct if only a subset of the functions are used, and the user is operating on the file system through the underlying library API anyway.

subsys/fs/Kconfig Outdated Show resolved Hide resolved
@JordanYates JordanYates changed the title fs: add FILE_SYSTEM_RAW_API option fs: add CONFIG_FILE_SYSTEM_LIB_LINK option Jul 29, 2024
@JordanYates
Copy link
Collaborator Author

I think this should be outside of if FILE_SYSTEM, and/or named FILE_SYSTEM_RAW_API_ONLY. Rationale is that you may want, for some reason, to use both and the Kconfig name is confusing as it enables something while it actually removes VFS support of file systems and restricts access to raw api only.

Updated along these lines. Instead of an option that implies some new behaviour, add a symbol which links in the filesystem libraries which is selected by CONFIG_FILE_SYSTEM. Applications that don't want CONFIG_FILE_SYSTEM are free to enable CONFIG_FILE_SYSTEM_LIB_LINK themselves.

@de-nordic de-nordic added this to the v4.0.0 milestone Jul 30, 2024
Add an option that links in the underlying file system libraries as
usual, but doesn't compile in the Zephyr file system abstraction layer.

This can be useful to avoid linking in the entire filesystem
implementation through the `fs_file_system_t` API struct if only a
subset of the functions are used.

Signed-off-by: Jordan Yates <[email protected]>
Copy link

github-actions bot commented Oct 2, 2024

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@fabiobaltieri fabiobaltieri merged commit bf9584d into zephyrproject-rtos:main Oct 2, 2024
23 checks passed
@JordanYates JordanYates deleted the 240711_fs_raw_api branch October 2, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants