Skip to content

Commit

Permalink
disk: simplify print_part_header()
Browse files Browse the repository at this point in the history
Using uclass_get_name() reduces the code size.

Signed-off-by: Heinrich Schuchardt <[email protected]>
  • Loading branch information
xypron authored and trini committed Apr 12, 2024
1 parent 9b6d415 commit 51b2f4f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 45 deletions.
47 changes: 3 additions & 44 deletions disk/part.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include <malloc.h>
#include <part.h>
#include <ubifs_uboot.h>
#include <dm/uclass.h>

#undef PART_DEBUG

Expand Down Expand Up @@ -305,50 +306,8 @@ static void print_part_header(const char *type, struct blk_desc *desc)
CONFIG_IS_ENABLED(ISO_PARTITION) || \
CONFIG_IS_ENABLED(AMIGA_PARTITION) || \
CONFIG_IS_ENABLED(EFI_PARTITION)
puts ("\nPartition Map for ");
switch (desc->uclass_id) {
case UCLASS_IDE:
puts ("IDE");
break;
case UCLASS_AHCI:
puts ("SATA");
break;
case UCLASS_SCSI:
puts ("SCSI");
break;
case UCLASS_USB:
puts ("USB");
break;
case UCLASS_MMC:
puts ("MMC");
break;
case UCLASS_HOST:
puts ("HOST");
break;
case UCLASS_NVME:
puts ("NVMe");
break;
case UCLASS_PVBLOCK:
puts("PV BLOCK");
break;
case UCLASS_RKMTD:
puts("RKMTD");
break;
case UCLASS_VIRTIO:
puts("VirtIO");
break;
case UCLASS_EFI_MEDIA:
puts("EFI");
break;
case UCLASS_BLKMAP:
puts("BLKMAP");
break;
default:
printf("UNKNOWN(%d)", desc->uclass_id);
break;
}
printf (" device %d -- Partition Type: %s\n\n",
desc->devnum, type);
printf("\nPartition Map for %s device %d -- Partition Type: %s\n\n",
uclass_get_name(desc->uclass_id), desc->devnum, type);
#endif /* any CONFIG_..._PARTITION */
}

Expand Down
2 changes: 1 addition & 1 deletion test/py/tests/test_scsi.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,6 @@ def test_scsi_dev(u_boot_console):
def test_scsi_part(u_boot_console):
test_scsi_dev(u_boot_console)
output = u_boot_console.run_command('scsi part')
assert 'Partition Map for SCSI device' in output
assert 'Partition Map for scsi device' in output
output = u_boot_console.run_command('echo $?')
assert output.endswith('0')

0 comments on commit 51b2f4f

Please sign in to comment.