Merge pull request microsoft#19204 from Kingwl/fix-completions-with-t…

…emplate-literal-type fix completions for string literal types with template string (microsoft#19162)
zfkl · Dec 19, 2017 · 89b5d8c · 89b5d8c
2 parents 1c4b9a5 + f1904a9
commit 89b5d8c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -238,7 +238,7 @@ namespace ts.Completions {
 
     function getStringLiteralCompletionEntries(sourceFile: SourceFile, position: number, typeChecker: TypeChecker, compilerOptions: CompilerOptions, host: LanguageServiceHost, log: Log): CompletionInfo | undefined {
         const node = findPrecedingToken(position, sourceFile);
-        if (!node || node.kind !== SyntaxKind.StringLiteral) {
+        if (!node || (node.kind !== SyntaxKind.StringLiteral && node.kind !== SyntaxKind.NoSubstitutionTemplateLiteral)) {
             return undefined;
         }
 
@@ -303,7 +303,7 @@ namespace ts.Completions {
 
             // Get completion for string literal from string literal type
             // i.e. var x: "hi" | "hello" = "/*completion position*/"
-            return getStringLiteralCompletionEntriesFromType(typeChecker.getContextualType(<StringLiteral>node), typeChecker);
+            return getStringLiteralCompletionEntriesFromType(typeChecker.getContextualType(<LiteralExpression>node), typeChecker);
         }
     }
 

diff --git a/.../cases/fourslash/completionListAfterStringLiteralTypeWithNoSubstitutionTemplateLiteral.ts b/.../cases/fourslash/completionListAfterStringLiteralTypeWithNoSubstitutionTemplateLiteral.ts
@@ -0,0 +1,8 @@
+/// <reference path="fourslash.ts" />
+
+////let count: 'one' | 'two';
+////count = `/**/`
+
+goTo.marker();
+verify.completionListContains('one');
+verify.completionListContains('two');