fix trim throwing regex error (sodiray#251)

zhaodahui · Jun 26, 2023 · 9981032 · 9981032
1 parent 9266717
commit 9981032
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/string.ts b/src/string.ts
@@ -135,6 +135,7 @@ export const trim = (
   charsToTrim: string = ' '
 ) => {
   if (!str) return ''
-  const regex = new RegExp(`^[${charsToTrim}]+|[${charsToTrim}]+$`, 'g')
+  const toTrim = charsToTrim.replace(/[\W]{1}/g, '\\$&')
+  const regex = new RegExp(`^[${toTrim}]+|[${toTrim}]+$`, 'g')
   return str.replace(regex, '')
 }
diff --git a/src/tests/string.test.ts b/src/tests/string.test.ts
@@ -185,5 +185,9 @@ describe('string module', () => {
       assert.equal(_.trim('//repos////', '/'), 'repos')
       assert.equal(_.trim('/repos/:owner/:repo/', '/'), 'repos/:owner/:repo')
     })
+
+    test('handles when char to trim is special case in regex', () => {
+      assert.equal(_.trim('_- hello_- ', '_- '), 'hello')
+    })
   })
 })