fix set function to allow falsy values (sodiray#263)

zhaodahui · Jun 26, 2023 · f2e6948 · f2e6948
1 parent 82fea7a
commit f2e6948
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/cdn/radash.esm.js b/cdn/radash.esm.js
@@ -702,7 +702,7 @@ const get = (value, path, defaultValue) => {
 const set = (initial, path, value) => {
   if (!initial)
     return {};
-  if (!path || !value)
+  if (!path || value === void 0)
     return initial;
   const segments = path.split(/[\.\[\]]/g).filter((x) => !!x.trim());
   const _set = (node) => {

diff --git a/cdn/radash.js b/cdn/radash.js
@@ -705,7 +705,7 @@ var radash = (function (exports) {
   const set = (initial, path, value) => {
     if (!initial)
       return {};
-    if (!path || !value)
+    if (!path || value === void 0)
       return initial;
     const segments = path.split(/[\.\[\]]/g).filter((x) => !!x.trim());
     const _set = (node) => {

diff --git a/src/object.ts b/src/object.ts
@@ -243,7 +243,7 @@ export const set = <T extends object, K>(
   value: K
 ): T => {
   if (!initial) return {} as T
-  if (!path || !value) return initial
+  if (!path || value === undefined) return initial
   const segments = path.split(/[\.\[\]]/g).filter(x => !!x.trim())
   const _set = (node: any) => {
     if (segments.length > 1) {

diff --git a/src/tests/object.test.ts b/src/tests/object.test.ts
@@ -450,6 +450,8 @@ describe('object module', () => {
       assert.deepEqual(_.set({}, '', null as any), {})
       assert.deepEqual(_.set(null as any, '', {}), {})
       assert.deepEqual(_.set(null as any, null as any, null as any), {})
+      assert.deepEqual(_.set({ foo: true }, 'foo', false), { foo: false })
+      assert.deepEqual(_.set({}, 'foo', 0), { foo: 0 })
     })
     test('sets deep values correctly', () => {
       assert.deepEqual(_.set({}, 'cards.value', 2), {