forked from apache/skywalking
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support span#error in toolkit (apache#2605)
* Fix apache#2546
- Loading branch information
Showing
11 changed files
with
652 additions
and
71 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
154 changes: 154 additions & 0 deletions
154
...rc/main/java/org/apache/skywalking/apm/toolkit/activation/trace/ActiveSpanActivation.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,154 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
*/ | ||
|
||
|
||
package org.apache.skywalking.apm.toolkit.activation.trace; | ||
|
||
import net.bytebuddy.description.method.MethodDescription; | ||
import net.bytebuddy.matcher.ElementMatcher; | ||
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.ClassStaticMethodsEnhancePluginDefine; | ||
import org.apache.skywalking.apm.agent.core.plugin.match.NameMatch; | ||
import org.apache.skywalking.apm.agent.core.plugin.interceptor.ConstructorInterceptPoint; | ||
import org.apache.skywalking.apm.agent.core.plugin.interceptor.StaticMethodsInterceptPoint; | ||
import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch; | ||
|
||
import static net.bytebuddy.matcher.ElementMatchers.named; | ||
import static net.bytebuddy.matcher.ElementMatchers.takesArguments; | ||
import static org.apache.skywalking.apm.agent.core.plugin.bytebuddy.ArgumentTypeNameMatch.takesArgumentWithType; | ||
|
||
/** | ||
* {@link TraceAnnotationActivation} enhance the <code>tag</code> method of <code>ActiveSpan</code> | ||
* by <code>ActiveSpanTagInterceptor</code>. | ||
* | ||
* @author zhangxin | ||
*/ | ||
public class ActiveSpanActivation extends ClassStaticMethodsEnhancePluginDefine { | ||
|
||
private static final String ENHANCE_CLASS = "org.apache.skywalking.apm.toolkit.trace.ActiveSpan"; | ||
|
||
private static final String TAG_INTERCEPTOR_CLASS = "org.apache.skywalking.apm.toolkit.activation.trace.ActiveSpanTagInterceptor"; | ||
private static final String TAG_INTERCEPTOR_METHOD_NAME = "tag"; | ||
|
||
private static final String ERROR_INTERCEPTOR_METHOD_NAME = "error"; | ||
private static final String ERROR_INTERCEPTOR_CLASS = "org.apache.skywalking.apm.toolkit.activation.trace.ActiveSpanErrorInterceptor"; | ||
private static final String ERROR_MSG_INTERCEPTOR_CLASS = "org.apache.skywalking.apm.toolkit.activation.trace.ActiveSpanErrorMsgInterceptor"; | ||
private static final String ERROR_THROWABLE_INTERCEPTOR_CLASS = "org.apache.skywalking.apm.toolkit.activation.trace.ActiveSpanErrorThrowableInteceptor"; | ||
|
||
private static final String DEBUG_INTERCEPTOR_METHOD_NAME = "debug"; | ||
private static final String DEBUG_INTERCEPTOR_CLASS = "org.apache.skywalking.apm.toolkit.activation.trace.ActiveSpanDebugInterceptor"; | ||
|
||
private static final String INFO_INTERCEPTOR_METHOD_NAME = "info"; | ||
private static final String INFO_INTERCEPTOR_CLASS = "org.apache.skywalking.apm.toolkit.activation.trace.ActiveSpanInfoInterceptor"; | ||
|
||
|
||
@Override protected ConstructorInterceptPoint[] getConstructorsInterceptPoints() { | ||
return new ConstructorInterceptPoint[0]; | ||
} | ||
|
||
@Override protected StaticMethodsInterceptPoint[] getStaticMethodsInterceptPoints() { | ||
return new StaticMethodsInterceptPoint[] { | ||
new StaticMethodsInterceptPoint() { | ||
@Override public ElementMatcher<MethodDescription> getMethodsMatcher() { | ||
return named(TAG_INTERCEPTOR_METHOD_NAME); | ||
} | ||
|
||
@Override public String getMethodsInterceptor() { | ||
return TAG_INTERCEPTOR_CLASS; | ||
} | ||
|
||
@Override public boolean isOverrideArgs() { | ||
return false; | ||
} | ||
}, | ||
new StaticMethodsInterceptPoint() { | ||
@Override public ElementMatcher<MethodDescription> getMethodsMatcher() { | ||
return named(DEBUG_INTERCEPTOR_METHOD_NAME) | ||
.and(takesArgumentWithType(0, "java.lang.String")); | ||
} | ||
|
||
@Override public String getMethodsInterceptor() { | ||
return DEBUG_INTERCEPTOR_CLASS; | ||
} | ||
|
||
@Override public boolean isOverrideArgs() { | ||
return false; | ||
} | ||
}, | ||
new StaticMethodsInterceptPoint() { | ||
@Override public ElementMatcher<MethodDescription> getMethodsMatcher() { | ||
return named(INFO_INTERCEPTOR_METHOD_NAME) | ||
.and(takesArgumentWithType(0, "java.lang.String")); | ||
} | ||
|
||
@Override public String getMethodsInterceptor() { | ||
return INFO_INTERCEPTOR_CLASS; | ||
} | ||
|
||
@Override public boolean isOverrideArgs() { | ||
return false; | ||
} | ||
}, | ||
new StaticMethodsInterceptPoint() { | ||
@Override public ElementMatcher<MethodDescription> getMethodsMatcher() { | ||
return named(ERROR_INTERCEPTOR_METHOD_NAME) | ||
.and(takesArgumentWithType(0, "java.lang.Throwable")); | ||
} | ||
|
||
@Override public String getMethodsInterceptor() { | ||
return ERROR_THROWABLE_INTERCEPTOR_CLASS; | ||
} | ||
|
||
@Override public boolean isOverrideArgs() { | ||
return false; | ||
} | ||
}, | ||
new StaticMethodsInterceptPoint() { | ||
@Override public ElementMatcher<MethodDescription> getMethodsMatcher() { | ||
return named(ERROR_INTERCEPTOR_METHOD_NAME) | ||
.and(takesArgumentWithType(0, "java.lang.String")); | ||
} | ||
|
||
@Override public String getMethodsInterceptor() { | ||
return ERROR_MSG_INTERCEPTOR_CLASS; | ||
} | ||
|
||
@Override public boolean isOverrideArgs() { | ||
return false; | ||
} | ||
}, | ||
new StaticMethodsInterceptPoint() { | ||
@Override public ElementMatcher<MethodDescription> getMethodsMatcher() { | ||
return named(ERROR_INTERCEPTOR_METHOD_NAME) | ||
.and(takesArguments(0)); | ||
} | ||
|
||
@Override public String getMethodsInterceptor() { | ||
return ERROR_INTERCEPTOR_CLASS; | ||
} | ||
|
||
@Override public boolean isOverrideArgs() { | ||
return false; | ||
} | ||
} | ||
}; | ||
} | ||
|
||
@Override protected ClassMatch enhanceClass() { | ||
return NameMatch.byName(ENHANCE_CLASS); | ||
} | ||
} |
58 changes: 58 additions & 0 deletions
58
...n/java/org/apache/skywalking/apm/toolkit/activation/trace/ActiveSpanDebugInterceptor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
*/ | ||
|
||
package org.apache.skywalking.apm.toolkit.activation.trace; | ||
|
||
import org.apache.skywalking.apm.agent.core.context.ContextManager; | ||
import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan; | ||
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult; | ||
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.StaticMethodsAroundInterceptor; | ||
|
||
import java.lang.reflect.Method; | ||
import java.util.HashMap; | ||
import java.util.Map; | ||
|
||
/** | ||
* @author caoyixiong | ||
*/ | ||
public class ActiveSpanDebugInterceptor implements StaticMethodsAroundInterceptor { | ||
@Override public void beforeMethod(Class clazz, Method method, Object[] allArguments, Class<?>[] parameterTypes, | ||
MethodInterceptResult result) { | ||
AbstractSpan activeSpan = null; | ||
try { | ||
activeSpan = ContextManager.activeSpan(); | ||
Map<String, String> event = new HashMap<String, String>(); | ||
event.put("event", "debug"); | ||
event.put("message", String.valueOf(allArguments[0])); | ||
activeSpan.log(System.currentTimeMillis(), event); | ||
|
||
} catch (NullPointerException e) { | ||
} | ||
} | ||
|
||
@Override public Object afterMethod(Class clazz, Method method, Object[] allArguments, Class<?>[] parameterTypes, | ||
Object ret) { | ||
return ret; | ||
} | ||
|
||
@Override | ||
public void handleMethodException(Class clazz, Method method, Object[] allArguments, Class<?>[] parameterTypes, | ||
Throwable t) { | ||
|
||
} | ||
} |
53 changes: 53 additions & 0 deletions
53
...n/java/org/apache/skywalking/apm/toolkit/activation/trace/ActiveSpanErrorInterceptor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
*/ | ||
|
||
|
||
package org.apache.skywalking.apm.toolkit.activation.trace; | ||
|
||
import org.apache.skywalking.apm.agent.core.context.ContextManager; | ||
import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan; | ||
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult; | ||
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.StaticMethodsAroundInterceptor; | ||
|
||
import java.lang.reflect.Method; | ||
|
||
/** | ||
* @author caoyixiong | ||
*/ | ||
public class ActiveSpanErrorInterceptor implements StaticMethodsAroundInterceptor { | ||
@Override public void beforeMethod(Class clazz, Method method, Object[] allArguments, Class<?>[] parameterTypes, | ||
MethodInterceptResult result) { | ||
AbstractSpan activeSpan = null; | ||
try { | ||
activeSpan = ContextManager.activeSpan(); | ||
activeSpan.errorOccurred(); | ||
} catch (NullPointerException e) { | ||
} | ||
} | ||
|
||
@Override public Object afterMethod(Class clazz, Method method, Object[] allArguments, Class<?>[] parameterTypes, | ||
Object ret) { | ||
return ret; | ||
} | ||
|
||
@Override | ||
public void handleMethodException(Class clazz, Method method, Object[] allArguments, Class<?>[] parameterTypes, | ||
Throwable t) { | ||
|
||
} | ||
} |
59 changes: 59 additions & 0 deletions
59
...ava/org/apache/skywalking/apm/toolkit/activation/trace/ActiveSpanErrorMsgInterceptor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
*/ | ||
|
||
package org.apache.skywalking.apm.toolkit.activation.trace; | ||
|
||
import org.apache.skywalking.apm.agent.core.context.ContextManager; | ||
import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan; | ||
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult; | ||
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.StaticMethodsAroundInterceptor; | ||
|
||
import java.lang.reflect.Method; | ||
import java.util.HashMap; | ||
import java.util.Map; | ||
|
||
/** | ||
* @author caoyixiong | ||
*/ | ||
public class ActiveSpanErrorMsgInterceptor implements StaticMethodsAroundInterceptor { | ||
@Override public void beforeMethod(Class clazz, Method method, Object[] allArguments, Class<?>[] parameterTypes, | ||
MethodInterceptResult result) { | ||
AbstractSpan activeSpan = null; | ||
try { | ||
activeSpan = ContextManager.activeSpan(); | ||
activeSpan.errorOccurred(); | ||
Map<String, String> event = new HashMap<String, String>(); | ||
event.put("event", "error"); | ||
event.put("message", String.valueOf(allArguments[0])); | ||
activeSpan.log(System.currentTimeMillis(), event); | ||
|
||
} catch (NullPointerException e) { | ||
} | ||
} | ||
|
||
@Override public Object afterMethod(Class clazz, Method method, Object[] allArguments, Class<?>[] parameterTypes, | ||
Object ret) { | ||
return ret; | ||
} | ||
|
||
@Override | ||
public void handleMethodException(Class clazz, Method method, Object[] allArguments, Class<?>[] parameterTypes, | ||
Throwable t) { | ||
|
||
} | ||
} |
Oops, something went wrong.