Skip to content

Commit

Permalink
indeo3dec: Fix end pointer.
Browse files Browse the repository at this point in the history
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <[email protected]>
  • Loading branch information
michaelni committed Mar 26, 2012
1 parent 7e496e1 commit 8a521d5
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions libavcodec/indeo3.c
Original file line number Diff line number Diff line change
Expand Up @@ -840,13 +840,13 @@ static int decode_plane(Indeo3DecodeContext *ctx, AVCodecContext *avctx,

/* each plane data starts with mc_vector_count field, */
/* an optional array of motion vectors followed by the vq data */
num_vectors = bytestream_get_le32(&data);
num_vectors = bytestream_get_le32(&data); data_size -= 4;
if (num_vectors > 256) {
av_log(ctx->avctx, AV_LOG_ERROR,
"Read invalid number of motion vectors %d\n", num_vectors);
return AVERROR_INVALIDDATA;
}
if (num_vectors * 2 >= data_size)
if (num_vectors * 2 > data_size)
return AVERROR_INVALIDDATA;

ctx->num_vectors = num_vectors;
Expand All @@ -857,7 +857,7 @@ static int decode_plane(Indeo3DecodeContext *ctx, AVCodecContext *avctx,
ctx->skip_bits = 0;
ctx->need_resync = 0;

ctx->last_byte = data + data_size - 1;
ctx->last_byte = data + data_size;

/* initialize the 1st cell and set its dimensions to whole plane */
curr_cell.xpos = curr_cell.ypos = 0;
Expand Down Expand Up @@ -894,6 +894,7 @@ static int decode_frame_headers(Indeo3DecodeContext *ctx, AVCodecContext *avctx,

/* parse the bitstream header */
bs_hdr = buf_ptr;
buf_size -= 16;

if (bytestream_get_le16(&buf_ptr) != 32) {
av_log(avctx, AV_LOG_ERROR, "Unsupported codec version!\n");
Expand Down

0 comments on commit 8a521d5

Please sign in to comment.