(fix) CountDownLatch is best placed into finally statement to avoid t…

…hread blocking when calls Closure#run(status) throw an exception (sofastack#713) Co-authored-by: penglong <[email protected]>
zhisrc · Nov 16, 2021 · 4b13f9b · 4b13f9b
1 parent e8b3976
commit 4b13f9b
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/jraft-core/src/main/java/com/alipay/sofa/jraft/closure/JoinableClosure.java b/jraft-core/src/main/java/com/alipay/sofa/jraft/closure/JoinableClosure.java
@@ -38,8 +38,11 @@ public JoinableClosure(Closure closure) {
 
     @Override
     public void run(final Status status) {
-        this.closure.run(status);
-        latch.countDown();
+        try {
+            this.closure.run(status);
+        } finally {
+            latch.countDown();
+        }
     }
 
     public void join() throws InterruptedException {