Fix bufferStorage bitfield #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current packed struct is wrong, it was implemented in the order which the flags are described in the OpenGL Spec. This is not how the bits are laid out in memory though, in fact if you were to write true to map_write with this implementation it would through a GL_INVALID_VALUE error since the function does not allow setting any bits besides the defined ones. This commit fixes the bitfield to have the correct order and padding aswell as providing their offsets as a comment and a small description of what each flag does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current packed struct is wrong, it was implemented in the order which the flags are described in the OpenGL Spec. This is not how the bits are laid out in memory though, in fact if you were to write true to map_write with this implementation it would through a GL_INVALID_VALUE error since the function does not allow setting any bits besides the defined ones. This commit fixes the bitfield to have the correct order and padding aswell as providing their offsets as a comment and a small description of what each flag does.