Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Schneider Electric Smoke Alarms #3897

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

uvNikita
Copy link
Contributor

Proposed change

Add support for Schneider Electric Smoke Alarms.

Reference to the original issue #1705

Specs: ZB Spec - Smoke Alarm -110422.pdf

image

Additional information

There are two issues from the logs:

  • Home Assistant complains when "y" is set as a duration unit ("Entity is using native unit of measurement 'y' which is not a valid unit for the device class ('duration') it is using; expected one of ['min', 'd', 'h', 's', 'ms'];"
  • "Test mode" switch should probably be under "Diagnostics", but then it fails with "does not have an entity class mapping" error similar to Quirks v2 unable to specify EntityType.DIAGNOSTIC for write_attr_button zha#291

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.99%. Comparing base (bd9ecbb) to head (e4cde7f).
Report is 9 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3897      +/-   ##
==========================================
+ Coverage   90.96%   90.99%   +0.02%     
==========================================
  Files         327      328       +1     
  Lines       10606    10637      +31     
==========================================
+ Hits         9648     9679      +31     
  Misses        958      958              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added needs review This PR should be reviewed soon, as it generally looks good. needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review This PR should be reviewed soon, as it generally looks good. needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants