Skip to content

Commit

Permalink
Fix jenkins from giving the green light to builds that don't compile.
Browse files Browse the repository at this point in the history
 Adding `| grep` swallows the non-zero return code from sbt failures. See [here](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13735/consoleFull) for a Jenkins run that fails to compile, but still gets a green light.

Note the [BUILD FIX] commit isn't actually part of this PR, but github is out of date.

Author: Michael Armbrust <[email protected]>

Closes apache#317 from marmbrus/fixJenkins and squashes the following commits:

7c77ff9 [Michael Armbrust] Remove output filter that was swallowing non-zero exit codes for test failures.
  • Loading branch information
marmbrus authored and rxin committed Apr 3, 2014
1 parent d94826b commit 9231b01
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dev/run-tests
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ dev/scalastyle
echo "========================================================================="
echo "Running Spark unit tests"
echo "========================================================================="
sbt/sbt assembly test | grep -v -e "info.*Resolving" -e "warn.*Merging" -e "info.*Including"
sbt/sbt assembly test

echo "========================================================================="
echo "Running PySpark tests"
Expand Down

0 comments on commit 9231b01

Please sign in to comment.