forked from iree-org/iree
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use separate Bazel invocation for TF integration binaries (iree-org#4836
) Rather than having CMake invoke Bazel itself, require that the necessary binaries be built prior to running CMake and then import them. This is similar to what iree-org#4584 did in the Android build and has similar advantages: the user can get these binaries in a variety of ways: building with their chosen config (e.g. with local or remote caching), installing prebuilt binaries, etc. It also is significantly more clear what's going on IMO. Having CMake invoke Bazel has caused a fair amount of confusion. Incidentally, I'm pretty sure this increases test coverage by enabling TF tests that were apparently not getting run. Tested: In addition to the CI, ran all the release distribution commands locally and confirmed they still exited successfully.
- Loading branch information
1 parent
3998012
commit f03c3c1
Showing
21 changed files
with
297 additions
and
341 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.