fix chart would not be destoried when that is unused

zjz1994 · Sep 3, 2017 · 031a8da · 031a8da
1 parent 213b53f
commit 031a8da
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/scripts/directives/chart.js b/src/scripts/directives/chart.js
@@ -38,6 +38,12 @@
                         setOptions(value);
                     }
                 }, true);
+
+                scope.$on('$destroy', function() {
+                    if (chart && !chart.isDisposed()) {
+                        chart.dispose();
+                    }
+                });
             }
         };
     }]).directive('ngPopChart', ['$window', 'chartTheme', function ($window, chartTheme) {
@@ -79,7 +85,7 @@
 
                     chart = echarts.init(wrapper[0], chartTheme.get(options.ngTheme));
                 }).on('hide.bs.popover', function () {
-                    if (chart && chart.isDisposed()) {
+                    if (chart && !chart.isDisposed()) {
                         chart.dispose();
                     }
                 }).on('hidden.bs.popover', function () {