Skip to content

Commit

Permalink
ceph.in: filter out audit from ceph -w
Browse files Browse the repository at this point in the history
...and add an optional --watch-channel argument.

Signed-off-by: John Spray <[email protected]>
  • Loading branch information
John Spray committed Jul 14, 2017
1 parent 1ac23e7 commit 1486397
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 6 deletions.
4 changes: 4 additions & 0 deletions PendingReleaseNotes
Original file line number Diff line number Diff line change
Expand Up @@ -203,3 +203,7 @@
* Certain extra fields in the 'ceph health' structured output that
used to appear if the mons were low on disk space (which duplicated
the information in the normal health warning messages) are now gone.

* The "ceph -w" output no longer contains audit log entries by default.
Add a "--watch-channel=audit" or "--watch-channel=*" to see them.

19 changes: 13 additions & 6 deletions src/ceph.in
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,11 @@ def parse_cmdargs(args=None, target=''):
parser.add_argument('--watch-error', action='store_true',
help='watch error events')

parser.add_argument('--watch-channel', dest="watch_channel",
help="which log channel to follow " \
"when using -w/--watch. One of ['cluster', 'audit', '*'",
default='cluster')

parser.add_argument('--version', '-v', action="store_true", help="display version")
parser.add_argument('--verbose', action="store_true", help="make verbose")
parser.add_argument('--concise', dest='verbose', action="store_false",
Expand Down Expand Up @@ -933,14 +938,16 @@ def main():
if k.startswith('watch') and v:
if k == 'watch':
level = 'info'
else:
elif k != "watch_channel":
level = k.replace('watch_', '')
if level:

# an awfully simple callback
def watch_cb(arg, line, who, stamp_sec, stamp_nsec, seq, level, msg):
print(line)
sys.stdout.flush()
def watch_cb(arg, line, channel, name, who, stamp_sec, stamp_nsec, seq, level, msg):
# Filter on channel
if (channel == parsed_args.watch_channel or \
parsed_args.watch_channel == "*"):
print(line)
sys.stdout.flush()

# first do a ceph status
ret, outbuf, outs = json_command(cluster_handle, prefix='status')
Expand All @@ -951,7 +958,7 @@ def main():

# this instance keeps the watch connection alive, but is
# otherwise unused
run_in_thread(cluster_handle.monitor_log, level, watch_cb, 0)
run_in_thread(cluster_handle.monitor_log2, level, watch_cb, 0)

# loop forever letting watch_cb print lines
try:
Expand Down

0 comments on commit 1486397

Please sign in to comment.