Skip to content

Commit

Permalink
Merge PR ceph#56354 into main
Browse files Browse the repository at this point in the history
* refs/pull/56354/head:
	qa/suites/fs/workload: enable snap_schedule early

Reviewed-by: Greg Farnum <[email protected]>
  • Loading branch information
batrick committed Mar 23, 2024
2 parents f6edcef + eb7b5c8 commit b3cfa10
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 3 deletions.
19 changes: 19 additions & 0 deletions qa/cephfs/begin/3-modules.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Enable mgr modules now before any CephFS mounts are created by the mgr. This
# avoids the potential race of the mgr mounting CephFS and then getting failed
# over by the monitors before the monitors have a chance to note the new client
# session from the mgr beacon. In that case, the monitors will not blocklist
# that client mount automatically so the MDS will eventually do the eviction
# (and create a cluster log warning which we want to avoid).
#
# Note: ideally the mgr would gently stop mgr modules before respawning so that
# the client mounts can be unmounted but this caused issues historically with
# modules like the dashboard so an abrupt restart was chosen instead.

mgrmodules:
sequential:
- print: "Enabling mgr modules"
# other fragments append to this

tasks:
- sequential:
- mgrmodules
1 change: 1 addition & 0 deletions qa/suites/fs/workload/begin/3-modules.yaml
10 changes: 7 additions & 3 deletions qa/suites/fs/workload/tasks/3-snaps/yes.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
mgrmodules:
sequential:
- exec:
mon.a:
- ceph mgr module enable snap_schedule
- ceph config set mgr mgr/snap_schedule/allow_m_granularity true
- ceph config set mgr mgr/snap_schedule/dump_on_update true
overrides:
ceph:
conf:
Expand All @@ -12,9 +19,6 @@ overrides:
tasks:
- exec:
mon.a:
- ceph mgr module enable snap_schedule
- ceph config set mgr mgr/snap_schedule/allow_m_granularity true
- ceph config set mgr mgr/snap_schedule/dump_on_update true
- ceph fs snap-schedule add --fs=cephfs --path=/ --snap_schedule=1m
- ceph fs snap-schedule retention add --fs=cephfs --path=/ --retention-spec-or-period=6m3h
- ceph fs snap-schedule status --fs=cephfs --path=/
Expand Down

0 comments on commit b3cfa10

Please sign in to comment.