Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding remove_obsidian_comments postprocessor to remove obsidian format comments #268

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Thompson-Jason
Copy link

Adding feature requested in issue #158 to remove Obsidian comments. As mentioned in PR #159 by @zoni I don't think it would be difficult to expand this postprocessor to instead of removing the comments making them HTML comments.

@Thompson-Jason Thompson-Jason marked this pull request as draft July 23, 2024 12:22
@Thompson-Jason Thompson-Jason marked this pull request as ready for review July 23, 2024 17:14
Copy link
Owner

@zoni zoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! Here's some non-exhaustive, preliminary comments from a quick review. 😄

Let me know if any of this is unclear and needs more explanation

src/main.rs Outdated Show resolved Hide resolved
src/postprocessors.rs Outdated Show resolved Hide resolved
Thompson-Jason and others added 4 commits August 5, 2024 17:11
@Thompson-Jason Thompson-Jason marked this pull request as draft August 6, 2024 20:46
@Thompson-Jason Thompson-Jason marked this pull request as ready for review August 7, 2024 02:44
@Thompson-Jason Thompson-Jason requested a review from zoni August 7, 2024 02:44
@Thompson-Jason
Copy link
Author

@zoni was there something more you felt this needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants