-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding remove_obsidian_comments postprocessor to remove obsidian format comments #268
Open
Thompson-Jason
wants to merge
9
commits into
zoni:main
Choose a base branch
from
Thompson-Jason:remove-comments
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments postprocessor.
…md to be used in the README
zoni
reviewed
Aug 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up! Here's some non-exhaustive, preliminary comments from a quick review. 😄
Let me know if any of this is unclear and needs more explanation
…g. Putting the Regex definition in a LazyCell. Adding logic to pop off codeblocks if they are inside a comment. Adding edge case to test.
…prove readability.
Thompson-Jason
force-pushed
the
remove-comments
branch
from
August 7, 2024 02:43
a88139d
to
e3aa83d
Compare
@zoni was there something more you felt this needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding feature requested in issue #158 to remove Obsidian comments. As mentioned in PR #159 by @zoni I don't think it would be difficult to expand this postprocessor to instead of removing the comments making them HTML comments.