Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trove - correct page number handling for newspapers #3410

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Trove - correct page number handling for newspapers #3410

merged 5 commits into from
Jan 27, 2025

Conversation

infrahistory
Copy link
Contributor

Updated newspaper scraper to correctly handle page number in Bibtex. Updated newspaper test case to include page number

infrahistory and others added 5 commits January 23, 2025 12:37
@infrahistory
Correct handling of page number in Bibtex for newspaper
97021f9
@infrahistory
correct test case attachment
4cbe0c3
@infrahistory
restore test case with addition of page value
12aa93a
@infrahistory
correct page handling
66975d0
@AbeJellinek
Tweaks
b0d0592 
- Restore old code, but run it conditionally
- Fix place remaining in publicationTitle
- Update existing tests
- Remove one test for item with bad metadata - we can fix and re-add in
  a separate PR
@AbeJellinek AbeJellinek merged commit a93eaee into zotero:master Jan 27, 2025
1 check failed
@AbeJellinek
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infrahistory @AbeJellinek