Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooltips: Fix the spacing between tooltip of Add Organisation #1408

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Prince-Singh-05
Copy link
Collaborator

@Prince-Singh-05 Prince-Singh-05 commented Feb 16, 2025

Fixes: #1087 - No spacing between tooltips of organisations
The space between the "Add Organisations" on left sidebar and it's tooltip was not the same as the other buttons on sidebar.
So, changed the left value of #add-server-tooltip,.server-tooltip in main.css to 60px.

Screenshots and screen captures:
Screenshot (203)

Platforms this PR was tested on:

  • Windows
  • macOS
  • Linux (Ubuntu 20.04)

Zulip-Desktop Version

  • Zulip-Desktop v5.11.1
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@Prince-Singh-05
Copy link
Collaborator Author

Prince-Singh-05 commented Feb 16, 2025

could anyone review this

@alya
Copy link
Collaborator

alya commented Feb 18, 2025

Thanks for the fix! Could you please update your commit message to match the commit style guidelines?

@Prince-Singh-05 Prince-Singh-05 changed the title #1087-No spacing between tooltips of organisations style: fixes the spacing between tooltips of organisations #1087 Feb 19, 2025
@Prince-Singh-05 Prince-Singh-05 changed the title style: fixes the spacing between tooltips of organisations #1087 style: fixes the spacing between tooltips of organisations Feb 19, 2025
@Prince-Singh-05
Copy link
Collaborator Author

@alya i have changed the commit message

@alya
Copy link
Collaborator

alya commented Feb 19, 2025

Unfortunately, that still doesn't follow the guidelines.

@Prince-Singh-05 Prince-Singh-05 changed the title style: fixes the spacing between tooltips of organisations tooltips: Fixes the spacing between tooltip of Add Organisations Feb 20, 2025
@Prince-Singh-05 Prince-Singh-05 changed the title tooltips: Fixes the spacing between tooltip of Add Organisations tooltips: Fix the spacing between tooltip of Add Organisation Feb 20, 2025
@Prince-Singh-05
Copy link
Collaborator Author

@alya i have made changes in commit message by going through the guidlines again, can you please suggest me a good commit message if it's still not good

@timabbott
Copy link
Member

No, you need to study the guidelines and learn how to write those yourself.

Also, see our documentation on proper before/after screenshots for visual changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants