remove unnecessary height calc

zxf2012 · Mar 4, 2016 · 37acbf4 · 37acbf4
1 parent c1f3f1f
commit 37acbf4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/shells/dev/target/index.js b/shells/dev/target/index.js
@@ -14,6 +14,8 @@ new Vue({
   template: `
     <div>
       <counter></counter>
+      <target></target>
+      <other></other>
     </div>
   `,
   components: { Target, Other, Counter },

diff --git a/src/devtools/components/ComponentInstance.vue b/src/devtools/components/ComponentInstance.vue
@@ -25,7 +25,7 @@
         {{ instance.inactive ? '(inactive)' : '' }}
       </span>
     </div>
-    <div v-if="expanded" :style="{ height: height + 'px' }">
+    <div v-if="expanded">
       <component-instance
         v-for="child in instance.children | orderBy 'inactive'"
         track-by="id"
@@ -50,9 +50,6 @@ export default {
       },
       selected ({ components: { inspectedInstance }}) {
         return this.instance.id === inspectedInstance.id
-      },
-      height ({ components: { expansionMap }}) {
-        return getInstanceHeight(this.instance, expansionMap)
       }
     },
     actions: {
@@ -79,16 +76,6 @@ export default {
     }
   }
 }
-
-function getInstanceHeight (instance, expansionMap) {
-  if (expansionMap[instance.id]) {
-    return Number(instance.children.map(child => {
-      return getInstanceHeight(child, expansionMap)
-    })) + 22
-  } else {
-    return 0
-  }
-}
 </script>
 
 <style lang="stylus" scoped>