Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep same order of files for amalgamation #481

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

evdenis
Copy link
Contributor

@evdenis evdenis commented Jan 31, 2024

According to the documentation glob returns files in arbitrary order. Let's sort paths to keep the same order of files for amalgamation.

@flobernd flobernd requested a review from athre0z January 31, 2024 14:55
According to the documentation glob returns files in arbitrary order.
Let's sort paths to keep the same order of files for amalgamation.

Signed-off-by: Denis Efremov <[email protected]>
@evdenis evdenis force-pushed the denis-amalgamate-files-order branch from 5434aa3 to 9cb7618 Compare January 31, 2024 15:58
@athre0z athre0z added C-enhancement Category: Enhancement of existing features A-build Area: Build system labels Jan 31, 2024
Copy link
Member

@athre0z athre0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :) CI failure is unrelated.

@athre0z athre0z merged commit 58f8c65 into zyantific:master Feb 4, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build Area: Build system C-enhancement Category: Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants