Deduplicate zh Gen5 met locations

StringQualityTests now passes again.
zyro670 · Mar 5, 2023 · 2c405f9 · 2c405f9
1 parent 284dd6d
commit 2c405f9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/PKHeX.Core/Resources/text/locations/gen5/text_bw2_00000_zh.txt b/PKHeX.Core/Resources/text/locations/gen5/text_bw2_00000_zh.txt
@@ -53,7 +53,7 @@ N的城堡
 联合塔
 泉源洞穴
 吹寄洞穴
-矢车森林
+思索之原
 天堂之塔
 雪花湿地
 R9购物广场
@@ -112,8 +112,8 @@ P2实验室
 双龙闸口
 黑色闸口
 白色闸口
+桥梁闸口
 道路闸口
-汇合大道
 海底遗迹
 桧扇市
 立涌市

diff --git a/Tests/PKHeX.Core.Tests/Util/StringQualityTests.cs b/Tests/PKHeX.Core.Tests/Util/StringQualityTests.cs
@@ -16,6 +16,7 @@ public class StringQualityTests
     [InlineData("es")]
     [InlineData("ko")]
     [InlineData("zh")]
+    [InlineData("zh2")]
     public void HasNoDuplicates(string language)
     {
         CheckMetLocations(language);
@@ -74,7 +75,7 @@ private static void CheckMetLocations(string language)
 
             foreach (var (bank, arr) in group.GetAll())
             {
-                var hs = new HashSet<string>();
+                var hs = new HashSet<string>(arr.Length);
                 bool sm0 = bank == 0 && name == nameof(GameStrings.Gen7);
                 for (int index = 0; index < arr.Length; index++)
                 {
@@ -85,7 +86,7 @@ private static void CheckMetLocations(string language)
                         continue;
 
                     if (hs.Contains(line))
-                        duplicates.Add($"{name}\t{line}");
+                        duplicates.Add($"{name}\t{index}\t{line}");
                     hs.Add(line);
                 }
             }