Skip to content

Commit

Permalink
[wasm] Cleanup the wasm fuzzer corpus files.
Browse files Browse the repository at this point in the history
In a recent CL I moved the corpus of the wasm fuzzer and of the
wasm-asmjs fuzzer to a different directory
(wasm_corpus and wasm_asmjs_corpus) so that the corpus is not executed
on the try-bots. With this CL I remove the old corpus from the
.gitignore file.

In addition I removed the hooks for wasm_corpus and
wasm_asmjs_corpus from the V8 DEPS file, because in a V8 checkout
they are not used anyway.

I also added code to the test runner to delete all *.wasm files
from the directories test/fuzzer/wasm and test/fuzzer/wasm_asmjs.
This code should be removed in a week, but it will help my coworkers
to cleanup their V8 checkout.



[email protected]
[email protected]

Change-Id: I9fdf9d77b71b133f84f7e744763d65fdf127d624
Reviewed-on: https://chromium-review.googlesource.com/505614
Commit-Queue: Andreas Haas <[email protected]>
Reviewed-by: Michael Achenbach <[email protected]>
Cr-Commit-Position: refs/heads/master@{#45417}
  • Loading branch information
gahaas authored and Commit Bot committed May 19, 2017
1 parent 58e6fe8 commit 2f92e9e
Show file tree
Hide file tree
Showing 7 changed files with 3 additions and 50 deletions.
4 changes: 0 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@
/test/fuzzer/wasm_corpus.tar.gz
/test/fuzzer/wasm_asmjs_corpus
/test/fuzzer/wasm_asmjs_corpus.tar.gz
/test/fuzzer/wasm
/test/fuzzer/wasm.tar.gz
/test/fuzzer/wasm_asmjs
/test/fuzzer/wasm_asmjs.tar.gz
/test/mozilla/data
/test/promises-aplus/promises-tests
/test/promises-aplus/promises-tests.tar.gz
Expand Down
44 changes: 0 additions & 44 deletions DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -212,50 +212,6 @@ hooks = [
"-s", "v8/test/wasm-spec-tests/tests.tar.gz.sha1",
],
},
{
"name": "wasm_fuzzer_new",
"pattern": ".",
"action": [ "download_from_google_storage",
"--no_resume",
"--no_auth",
"-u",
"--bucket", "v8-wasm-fuzzer",
"-s", "v8/test/fuzzer/wasm_corpus.tar.gz.sha1",
],
},
{
"name": "wasm_fuzzer",
"pattern": ".",
"action": [ "download_from_google_storage",
"--no_resume",
"--no_auth",
"-u",
"--bucket", "v8-wasm-fuzzer",
"-s", "v8/test/fuzzer/wasm.tar.gz.sha1",
],
},
{
"name": "wasm_asmjs_fuzzer_new",
"pattern": ".",
"action": [ "download_from_google_storage",
"--no_resume",
"--no_auth",
"-u",
"--bucket", "v8-wasm-asmjs-fuzzer",
"-s", "v8/test/fuzzer/wasm_asmjs_corpus.tar.gz.sha1",
],
},
{
"name": "wasm_asmjs_fuzzer",
"pattern": ".",
"action": [ "download_from_google_storage",
"--no_resume",
"--no_auth",
"-u",
"--bucket", "v8-wasm-asmjs-fuzzer",
"-s", "v8/test/fuzzer/wasm_asmjs.tar.gz.sha1",
],
},
{
"name": "closure_compiler",
"pattern": ".",
Expand Down
3 changes: 3 additions & 0 deletions test/fuzzer/testcfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ def ListTests(self, context):
for subtest in FuzzerTestSuite.SUB_TESTS:
shell = 'v8_simple_%s_fuzzer' % subtest
for fname in os.listdir(os.path.join(self.root, subtest)):
if subtest in ["wasm", "wasm_asmjs"] and fname.endswith(".wasm"):
os.remove(os.path.join(self.root, subtest, fname))
continue
if not os.path.isfile(os.path.join(self.root, subtest, fname)):
continue
test = testcase.TestCase(self, '%s/%s' % (subtest, fname),
Expand Down
1 change: 0 additions & 1 deletion test/fuzzer/wasm.tar.gz.sha1

This file was deleted.

Empty file added test/fuzzer/wasm/foo
Empty file.
1 change: 0 additions & 1 deletion test/fuzzer/wasm_asmjs.tar.gz.sha1

This file was deleted.

Empty file added test/fuzzer/wasm_asmjs/foo
Empty file.

0 comments on commit 2f92e9e

Please sign in to comment.