feat(impress): Allow inserting multimedia #10204
Open
+211
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minion3665
force-pushed
the
private/skyler/push-vxmsrxlrnvtn
branch
from
2f63901
to
2052992
Compare
Minion3665
force-pushed
the
private/skyler/push-vxmsrxlrnvtn
branch
2 times, most recently
from
91ec469
to
8a2c5b7
Compare
Previously we could play videos/audio inserted from LibreOffice, but had no way to insert them from online. This commit adds a new "Multimedia" button to the insert menu of impress, which supports inserting different audio/video formats. This relies on https://gerrit.libreoffice.org/c/core/+/174740 (or to be running inproc in some environments where the sandboxing is weaker) as otherwise it is unable to send the size of the inserted video to core, which will cause core to fail to insert the new element. Signed-off-by: Skyler Grey <[email protected]> Change-Id: I881818277edb69ee1e98ba1bd3454e8d29593889
In I881818277edb69ee1e98ba1bd3454e8d29593889, we allowed multimedia to be inserted. Let's test it to make sure that the media we insert shows up Signed-off-by: Skyler Grey <[email protected]> Change-Id: I1f1f64f76d39791cdf7f460c9452fe4e9c6eff4c
Minion3665
force-pushed
the
private/skyler/push-vxmsrxlrnvtn
branch
from
8a2c5b7
to
46b0094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we could play videos/audio inserted from LibreOffice, but had no way to insert them from online. This commit adds a new "Multimedia" button to the insert menu of impress, which supports inserting different audio/video formats.
This relies on https://gerrit.libreoffice.org/c/core/+/174740 (or to be running inproc in some environments where the sandboxing is weaker) as otherwise it is unable to send the size of the inserted video to core, which will cause core to fail to insert the new element.
Change-Id: I881818277edb69ee1e98ba1bd3454e8d29593889
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay