Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(impress): Allow inserting multimedia #10204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(impress): Allow inserting multimedia #10204

wants to merge 2 commits into from

Commits on Oct 10, 2024

  1. feat(impress): Allow inserting multimedia 

    Previously we could play videos/audio inserted from LibreOffice, but had
no way to insert them from online. This commit adds a new "Multimedia"
button to the insert menu of impress, which supports inserting different
audio/video formats.

This relies on https://gerrit.libreoffice.org/c/core/+/174740 (or to be
running inproc in some environments where the sandboxing is weaker) as
otherwise it is unable to send the size of the inserted video to core,
which will cause core to fail to insert the new element.

Signed-off-by: Skyler Grey <[email protected]>
Change-Id: I881818277edb69ee1e98ba1bd3454e8d29593889
    @Minion3665
    Minion3665 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b001a56 View commit details
    Browse the repository at this point in the history

  2. test(impress): Allow inserting multimedia 

    In I881818277edb69ee1e98ba1bd3454e8d29593889, we allowed multimedia to
be inserted. Let's test it to make sure that the media we insert shows
up

Signed-off-by: Skyler Grey <[email protected]>
Change-Id: I1f1f64f76d39791cdf7f460c9452fe4e9c6eff4c
    @Minion3665
    Minion3665 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    46b0094 View commit details
    Browse the repository at this point in the history