-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caleb/fix/this #227
Merged
Merged
Caleb/fix/this #227
Changes from 1 commit
Commits
Show all changes
229 commits
Select commit
Hold shift + click to select a range
ede9026
chore(JSObjectProxy): add missing include guard
zollqir 8e235b5
feat(PyObjectProxyHandler): implement an opaque type wrapper
zollqir 677f643
feat(JSFunctionProxy): implement JSFunctionProxy, JSMethodProxy, and …
zollqir 654ddd9
feat(JSStringProxy): implement JSStringProxy, as well as replace memo…
zollqir d731d3e
Merge branch 'main' into caleb/fix/this
zollqir f439f96
fix JSArrayProxy and PyListProxy sort with proxied function arguments
zollqir a2cfa8d
Merge branch 'main' into caleb/fix/this
zollqir e4f4d90
added globalThis tests
philippedistributive a5b12a5
cleanup
philippedistributive 71269e7
value parameter to PyTypeFactory no longer needs to be allocated on t…
philippedistributive cb3feef
cleanup
philippedistributive 13938db
should have been part of the previous commit
philippedistributive c1fbc1f
pyTypeFactory use HandleValue instead of pointer
philippedistributive 636fcde
cleanup
philippedistributive b5bd094
should have bee part of previous commit
philippedistributive fade8f0
cleanup
philippedistributive fee7bf3
typo fix
philippedistributive 695c71a
crash fix
philippedistributive 234da46
test for crash fix
philippedistributive 324ad7a
added test for issue #58
philippedistributive 2f5264f
better naming
philippedistributive 0998b84
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive 839d3e8
cleanup
philippedistributive a7d7a1a
should have been part of the previous commit
philippedistributive 7b17b0f
added array test
philippedistributive 982f578
cleanup test that uses CryptoJS
philippedistributive d0ed527
cleanup after test
philippedistributive a7348de
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive 428005a
cleanup
philippedistributive 8e827f9
formatting
philippedistributive 15db758
added iterator test
philippedistributive 050096f
crash fix and its test
philippedistributive 20a8227
assign to list beyond current length js-style
philippedistributive 2d934fe
comment
philippedistributive 6395687
cleanup
philippedistributive 10c8c79
improved naming
philippedistributive de32916
formatting
philippedistributive c827e66
added missing pyExceptions
philippedistributive 8f2408f
no Py_SET_SIZE on python 3.8
philippedistributive 95a1b4d
removed incorrect comment
philippedistributive 1dc7dd1
missing file headers improved
philippedistributive 2d1462d
type improvement
philippedistributive 9ff38bc
improved comment
philippedistributive 6f25813
fix(JSObjectProxy): correctly handle 'this' value of methods on JSObj…
zollqir 7b2b613
test(JSObjectProxy): added test for issue #172
zollqir 5ab92c8
chore(meta): update all top-of-file comments
zollqir 18fde47
cleanup: no need for overriding methods that merely call super. prope…
philippedistributive 4d1d9c2
cleanup
philippedistributive cc13130
further cleanup
philippedistributive 32d2d41
added missing file headers. cleanup
philippedistributive 7843271
further cleanup
philippedistributive 809b5fa
improved comment
philippedistributive 976327b
fixed copyright headers
philippedistributive 1884f79
uniform copyright headers
philippedistributive bcf55ae
last missing copyrights. license statements fixes
philippedistributive e2f446e
improved comment
philippedistributive 5153405
logic improvement
philippedistributive 454b943
improved naming
philippedistributive a26680e
cleanup
philippedistributive 20013a4
project at advanced stage
philippedistributive d946421
copyright headers missing and documentation cleanup
philippedistributive 1f42778
further cleanup and missing copyrights
philippedistributive c484f7e
more missing copyrights
philippedistributive 7ed1022
chore(JSFunctionProxy): remove unnecessary return on JSFunctionProxy_…
zollqir 968ef9c
refactor(JSFunctionProxy): remove loop invariant in JSFunctionProxy_c…
zollqir 4ce69b1
refactor(PyObjectProxyHandler): remove one-use variable
zollqir f4ba03a
feat(PyObjectProxyHandler): set Object prototype on PyObjectProxyHand…
zollqir 251d9cc
fix(JSMethodProxy): correctly increment JSMethodProxy when accessing …
zollqir 98b21d6
feat(PyObjectProxyHandler): store proxied PyObject in reserved slot
zollqir b30b570
can now assign arguments directly from sys.arg
philippedistributive 2f5a0c6
refactor(jsTypeFactory.cc): remove obvious comment
zollqir 7f5bb55
refactor(JSFunctionProxy): remove extra line from JSFunctionProxy_call
zollqir 519e784
refactor(pyTypeFactory): remove one-use variables
zollqir a16436d
updates
philippedistributive a93fcd2
English fix and improved organization
philippedistributive ea2a2ec
no more leak with the second parameter of pyTypeFactory
philippedistributive e970277
refactor(PyBaseProxyHandler): refactor shared code
zollqir b9250f9
fixed english
philippedistributive dba06b3
test(PyObjectProxyHandler): write a test suit for
zollqir 2702183
refactor(pyTypeFactory): refactor pyTypeFactory to use recursive
zollqir 3de663d
chore(TODO): resolve various TODOs related to
zollqir cb57161
more precise error reporting
philippedistributive e28e160
simplification
philippedistributive 9416d92
fix(JSFunctionProxy): correctly error out if an
zollqir cdceef1
crash fix
philippedistributive d6b8abd
fix(FinalizationRegistry): set the
zollqir 0d927f2
Merge branch 'main' into caleb/fix/this
philippedistributive 572f3f2
fix(eval): remove the need to permanently root
zollqir 6cd7d69
Merge branch 'main' into caleb/fix/this
philippedistributive fde84e7
Merge branch 'main' into caleb/fix/this
philippedistributive 7a8ac9b
chore(PyListProxyHandler): remove unnecessary error
zollqir 481f04b
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive 54cb096
cleanup
philippedistributive 7172cff
jsObject/jsArray should be persistentrooted
philippedistributive 28fd039
cleanup unused methods
philippedistributive b0a8e0f
cleanup and minor improvements
philippedistributive 593da22
dict conversion no longer needed now that we have proxies
philippedistributive c23ec95
Merge branch 'main' into caleb/fix/this
philippedistributive 6952028
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive f787578
improved setdefault performance
philippedistributive e248b44
decref the result of python calls. Rooted type simplifications
philippedistributive 943bb1d
fix file header attributions
philippedistributive 118c8ca
feat(PyListProxyHandler): implement and add tests
zollqir 850508c
improved clear methods and related naming, variable folding
philippedistributive 66448e2
docs(JSMethodProxy): write docs describing how to
zollqir 763bd44
fix on clear method, incref in object.get
philippedistributive 2ec0b4e
Merge branch 'caleb/fix/this' of https://github.com/Distributive-Netw…
zollqir ee5c738
heap-allocated root should be persistent
philippedistributive 0af763c
Revert "chore(meta): update all top-of-file comments"
zollqir 1276a9a
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive 889c912
remove unused second parameter to pyTypeFactory
philippedistributive 4ba97f7
increment firefox version
philippedistributive 4df71ee
version update
philippedistributive 85dd1ee
chore(PyDictOrObjectProxyHandler): remove blank line
zollqir c4afd10
refactor(PyDictOrObjectProxyHandler): refactor the
zollqir edb9f69
chore(PyProxyHandlers): remove TODO comments about
zollqir 61b2875
chore(tests): remove extra empty lines from
zollqir ba1afb8
use PersistentRooted pointer instead of inline in struct for Object a…
philippedistributive a0fea0c
chore(jsTypeFactory): remove extra blank lines from
zollqir ccbd1c5
chore(FinalizationRegistry): change
zollqir b4d33b4
feat(jsTypeFactory): correctly check the result of
zollqir 30c120d
tp_name must be same as that of super type
philippedistributive f8a1217
finished details of JSObjectProxy.repr: skip over the $super key to a…
philippedistributive 9733902
next version will be 0.4.0
philippedistributive 4414c94
Merge branch 'main' into caleb/fix/this
philippedistributive 1849dbf
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive c6b06a5
Merge branch 'main' into caleb/fix/this
philippedistributive ec03ef9
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive c4dc2bd
hash not implemented entry not required
philippedistributive 40bdbb3
test fix
philippedistributive 56e3af9
Merge branch 'main' into caleb/fix/this
philippedistributive 4097f36
chore(PyObjectProxyHandler): don't use python C
zollqir 9ba0e7e
Merge branch 'main' into caleb/fix/this
philippedistributive e9c6d1a
Merge branch 'main' into caleb/fix/this
philippedistributive 0765086
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive 7e7ed33
improved reference management
philippedistributive baab95f
dec ref needs to check for null
philippedistributive f8aafd8
feat(FinalizationRegistry): implement job queue
zollqir 5ed221b
fix(pythonmonkey): delete the JobQueue & JSContext
zollqir cb92513
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive 9764d1f
post-merge patch-up
philippedistributive dec4f72
Proxies now use parent type name for enhanced type compatibility
philippedistributive 0e214c1
Merge branch 'main' into caleb/fix/this
philippedistributive a909fc7
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive 0bd5c27
Merge branch 'main' into caleb/fix/this
philippedistributive bfc7798
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive c2d102d
cleanup and post-merge adjust
philippedistributive 5fa62df
post-merge fixup
philippedistributive c645fca
include cleanup
philippedistributive a61ad04
Merge branch 'main' into caleb/fix/this
philippedistributive b986a4c
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive 1c0670c
Merge branch 'main' into caleb/fix/this
philippedistributive 9c0524f
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive 8668e3d
refactor(PyBaseProxyHandler): remvoe PyDictOrObjectProxyHandler
zollqir 8622867
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive bf16c39
enhanced python stack trace tests
philippedistributive 7abbd1b
Revert "enhanced python stack trace tests"
philippedistributive f88cfd2
test fix
philippedistributive 25f6134
Full JS stacks provided in the context of a Python Exception while ca…
philippedistributive 7eaab5e
improved comment
philippedistributive 93fb621
one more comment
philippedistributive 015eb14
added test for array subclass
philippedistributive 73f068a
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive b58b0ac
adjustment to __class__ implementation and added test
philippedistributive 453ded4
Update src/ExceptionType.cc
philippedistributive 327ab26
proper exception stack type
philippedistributive fbcb81c
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive 703acad
Merge branch 'main' into caleb/fix/this
philippedistributive 8dfaa43
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive 993da0e
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive f72168e
Merge branch 'main' into caleb/fix/this
philippedistributive b52383c
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive cee3fb0
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive 66dbb97
adjustment to __class__ for arrayproxy
philippedistributive 501f26d
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive e08f74b
cleanup
philippedistributive 9ddda1a
Merge branch 'main' into caleb/fix/this
philippedistributive 20a47d4
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive 8c7bce7
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive 77f460b
Update src/jsTypeFactory.cc
philippedistributive c627e30
Revert "Update src/jsTypeFactory.cc"
philippedistributive f9c29ad
remove commented-out code
philippedistributive 3cd6397
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive f44db82
Merge branch 'main' into caleb/fix/this
philippedistributive e08a1e7
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive 76aa711
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive 55265ae
Merge branch 'main' into caleb/fix/this
philippedistributive 073972b
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive 6d447c6
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive e5a82e6
remove duplicate JS stack trace
philippedistributive da5f621
logic improvement
philippedistributive e8c439a
cleanup
philippedistributive 0dc70af
logic improvement
philippedistributive 9d737fd
newline not needed
philippedistributive 93888de
Merge pull request #296 from Distributive-Network/philippe/full-js-an…
philippedistributive dd5e156
entry newline needed
philippedistributive c7e6a6c
Merge branch 'main' into caleb/fix/this
philippedistributive 1adaabb
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive c544529
chore(CI): add core dumps to CI
zollqir 1fff0de
Merge branch 'caleb/fix/this' of https://github.com/Distributive-Netw…
zollqir a2884c1
chore(CI): fix test-and-publish.yaml syntax error
zollqir 27019d2
added get method test
philippedistributive 86805ba
chore(CI): fix missing then in test-and-publish.yaml
zollqir df32a3c
allow object key to shadow method
philippedistributive 1068741
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive 78f9938
do distinguish between dict . and [] operators
philippedistributive c0a1af8
Merge branch 'philippe/pyTypeFactory-cleanup' of github.com:Distribut…
philippedistributive 708a560
chore(CI): add tmate debugging to Actions runner
zollqir 73e57c8
chore(CI): add -p flag to mkdir /cores
zollqir fd78561
chore(CI): upgrade deprecated actions
zollqir 6c47748
chore(CI): add osname and python version to core dump
zollqir c69ea53
chore(CI): upgrade deprecated upload-artifact action
zollqir c2fdfa8
chore(CI): fix core dump names for Mac
zollqir 1b444e0
chore(CI): name core dump artifact in Github Actions
zollqir b944db4
Revert "chore(CI): upgrade deprecated upload-artifact action"
zollqir 96cb24d
chore(CI): fix core dump artifact name, only upload cores on failure
zollqir 1e9ec27
chore(CI): run JS tests even if python tests fail
zollqir 216545b
chore(CI): fix yaml syntax error
zollqir 398baa8
chore(CI): add dump_cores input to CI workflow dispatch
zollqir ee8c33a
chore(CI): only set core names if cores will be dumped
zollqir 3cb7ebc
no need for cpython GC compatibility for these
philippedistributive 6452123
chore(meta): add logging of python libs during compilation
zollqir c54d5e8
Merge branch 'main' into caleb/fix/this
philippedistributive 8aab622
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive a2d818a
post-merge fixup
philippedistributive fba9c25
fix(JobQueue): allocate callbacks on the heap and delete global befor…
zollqir 74ceb71
fix(JobQueue): don't double-free finalizationRegistryCallbacks vector
zollqir e77be01
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive 00dfec4
Merge pull request #234 from Distributive-Network/philippe/pyTypeFact…
philippedistributive File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(eval): remove the need to permanently root
JSFunctions returned by eval. TODO: still need to solve JSStrings being permanently rooted when returned by eval.
- Loading branch information
commit 572f3f24c4442862af590be6e28a897e8a33f1be
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok we said we do this now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
till seperate PR