Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caleb/fix/this #227

Merged
merged 229 commits into from
Apr 3, 2024
Merged
Changes from 1 commit
Commits
Show all changes
229 commits
Select commit Hold shift + click to select a range
ede9026
chore(JSObjectProxy): add missing include guard
zollqir Nov 22, 2023
8e235b5
feat(PyObjectProxyHandler): implement an opaque type wrapper
zollqir Nov 22, 2023
677f643
feat(JSFunctionProxy): implement JSFunctionProxy, JSMethodProxy, and …
zollqir Nov 24, 2023
654ddd9
feat(JSStringProxy): implement JSStringProxy, as well as replace memo…
zollqir Jan 17, 2024
d731d3e
Merge branch 'main' into caleb/fix/this
zollqir Jan 30, 2024
f439f96
fix JSArrayProxy and PyListProxy sort with proxied function arguments
zollqir Jan 31, 2024
a2cfa8d
Merge branch 'main' into caleb/fix/this
zollqir Jan 31, 2024
e4f4d90
added globalThis tests
philippedistributive Feb 1, 2024
a5b12a5
cleanup
philippedistributive Feb 1, 2024
71269e7
value parameter to PyTypeFactory no longer needs to be allocated on t…
philippedistributive Feb 1, 2024
cb3feef
cleanup
philippedistributive Feb 1, 2024
13938db
should have been part of the previous commit
philippedistributive Feb 1, 2024
c1fbc1f
pyTypeFactory use HandleValue instead of pointer
philippedistributive Feb 2, 2024
636fcde
cleanup
philippedistributive Feb 2, 2024
b5bd094
should have bee part of previous commit
philippedistributive Feb 2, 2024
fade8f0
cleanup
philippedistributive Feb 2, 2024
fee7bf3
typo fix
philippedistributive Feb 2, 2024
695c71a
crash fix
philippedistributive Feb 2, 2024
234da46
test for crash fix
philippedistributive Feb 2, 2024
324ad7a
added test for issue #58
philippedistributive Feb 2, 2024
2f5264f
better naming
philippedistributive Feb 2, 2024
0998b84
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Feb 2, 2024
839d3e8
cleanup
philippedistributive Feb 5, 2024
a7d7a1a
should have been part of the previous commit
philippedistributive Feb 5, 2024
7b17b0f
added array test
philippedistributive Feb 5, 2024
982f578
cleanup test that uses CryptoJS
philippedistributive Feb 5, 2024
d0ed527
cleanup after test
philippedistributive Feb 5, 2024
a7348de
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Feb 5, 2024
428005a
cleanup
philippedistributive Feb 5, 2024
8e827f9
formatting
philippedistributive Feb 5, 2024
15db758
added iterator test
philippedistributive Feb 6, 2024
050096f
crash fix and its test
philippedistributive Feb 6, 2024
20a8227
assign to list beyond current length js-style
philippedistributive Feb 6, 2024
2d934fe
comment
philippedistributive Feb 6, 2024
6395687
cleanup
philippedistributive Feb 6, 2024
10c8c79
improved naming
philippedistributive Feb 6, 2024
de32916
formatting
philippedistributive Feb 6, 2024
c827e66
added missing pyExceptions
philippedistributive Feb 6, 2024
8f2408f
no Py_SET_SIZE on python 3.8
philippedistributive Feb 6, 2024
95a1b4d
removed incorrect comment
philippedistributive Feb 6, 2024
1dc7dd1
missing file headers improved
philippedistributive Feb 6, 2024
2d1462d
type improvement
philippedistributive Feb 6, 2024
9ff38bc
improved comment
philippedistributive Feb 6, 2024
6f25813
fix(JSObjectProxy): correctly handle 'this' value of methods on JSObj…
zollqir Feb 7, 2024
7b2b613
test(JSObjectProxy): added test for issue #172
zollqir Feb 7, 2024
5ab92c8
chore(meta): update all top-of-file comments
zollqir Feb 7, 2024
18fde47
cleanup: no need for overriding methods that merely call super. prope…
philippedistributive Feb 7, 2024
4d1d9c2
cleanup
philippedistributive Feb 7, 2024
cc13130
further cleanup
philippedistributive Feb 7, 2024
32d2d41
added missing file headers. cleanup
philippedistributive Feb 7, 2024
7843271
further cleanup
philippedistributive Feb 7, 2024
809b5fa
improved comment
philippedistributive Feb 7, 2024
976327b
fixed copyright headers
philippedistributive Feb 7, 2024
1884f79
uniform copyright headers
philippedistributive Feb 7, 2024
bcf55ae
last missing copyrights. license statements fixes
philippedistributive Feb 7, 2024
e2f446e
improved comment
philippedistributive Feb 7, 2024
5153405
logic improvement
philippedistributive Feb 8, 2024
454b943
improved naming
philippedistributive Feb 8, 2024
a26680e
cleanup
philippedistributive Feb 8, 2024
20013a4
project at advanced stage
philippedistributive Feb 8, 2024
d946421
copyright headers missing and documentation cleanup
philippedistributive Feb 8, 2024
1f42778
further cleanup and missing copyrights
philippedistributive Feb 8, 2024
c484f7e
more missing copyrights
philippedistributive Feb 8, 2024
7ed1022
chore(JSFunctionProxy): remove unnecessary return on JSFunctionProxy_…
zollqir Feb 9, 2024
968ef9c
refactor(JSFunctionProxy): remove loop invariant in JSFunctionProxy_c…
zollqir Feb 9, 2024
4ce69b1
refactor(PyObjectProxyHandler): remove one-use variable
zollqir Feb 9, 2024
f4ba03a
feat(PyObjectProxyHandler): set Object prototype on PyObjectProxyHand…
zollqir Feb 9, 2024
251d9cc
fix(JSMethodProxy): correctly increment JSMethodProxy when accessing …
zollqir Feb 9, 2024
98b21d6
feat(PyObjectProxyHandler): store proxied PyObject in reserved slot
zollqir Feb 9, 2024
b30b570
can now assign arguments directly from sys.arg
philippedistributive Feb 9, 2024
2f5a0c6
refactor(jsTypeFactory.cc): remove obvious comment
zollqir Feb 9, 2024
7f5bb55
refactor(JSFunctionProxy): remove extra line from JSFunctionProxy_call
zollqir Feb 9, 2024
519e784
refactor(pyTypeFactory): remove one-use variables
zollqir Feb 9, 2024
a16436d
updates
philippedistributive Feb 9, 2024
a93fcd2
English fix and improved organization
philippedistributive Feb 9, 2024
ea2a2ec
no more leak with the second parameter of pyTypeFactory
philippedistributive Feb 9, 2024
e970277
refactor(PyBaseProxyHandler): refactor shared code
zollqir Feb 13, 2024
b9250f9
fixed english
philippedistributive Feb 13, 2024
dba06b3
test(PyObjectProxyHandler): write a test suit for
zollqir Feb 14, 2024
2702183
refactor(pyTypeFactory): refactor pyTypeFactory to use recursive
zollqir Feb 14, 2024
3de663d
chore(TODO): resolve various TODOs related to
zollqir Feb 15, 2024
cb57161
more precise error reporting
philippedistributive Feb 15, 2024
e28e160
simplification
philippedistributive Feb 15, 2024
9416d92
fix(JSFunctionProxy): correctly error out if an
zollqir Feb 15, 2024
cdceef1
crash fix
philippedistributive Feb 16, 2024
d6b8abd
fix(FinalizationRegistry): set the
zollqir Feb 16, 2024
0d927f2
Merge branch 'main' into caleb/fix/this
philippedistributive Feb 16, 2024
572f3f2
fix(eval): remove the need to permanently root
zollqir Feb 16, 2024
6cd7d69
Merge branch 'main' into caleb/fix/this
philippedistributive Feb 16, 2024
fde84e7
Merge branch 'main' into caleb/fix/this
philippedistributive Feb 16, 2024
7a8ac9b
chore(PyListProxyHandler): remove unnecessary error
zollqir Feb 19, 2024
481f04b
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Feb 22, 2024
54cb096
cleanup
philippedistributive Feb 22, 2024
7172cff
jsObject/jsArray should be persistentrooted
philippedistributive Feb 23, 2024
28fd039
cleanup unused methods
philippedistributive Feb 26, 2024
b0a8e0f
cleanup and minor improvements
philippedistributive Feb 26, 2024
593da22
dict conversion no longer needed now that we have proxies
philippedistributive Feb 26, 2024
c23ec95
Merge branch 'main' into caleb/fix/this
philippedistributive Feb 27, 2024
6952028
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Feb 27, 2024
f787578
improved setdefault performance
philippedistributive Feb 27, 2024
e248b44
decref the result of python calls. Rooted type simplifications
philippedistributive Feb 27, 2024
943bb1d
fix file header attributions
philippedistributive Feb 27, 2024
118c8ca
feat(PyListProxyHandler): implement and add tests
zollqir Feb 27, 2024
850508c
improved clear methods and related naming, variable folding
philippedistributive Feb 27, 2024
66448e2
docs(JSMethodProxy): write docs describing how to
zollqir Feb 27, 2024
763bd44
fix on clear method, incref in object.get
philippedistributive Feb 27, 2024
2ec0b4e
Merge branch 'caleb/fix/this' of https://github.com/Distributive-Netw…
zollqir Feb 28, 2024
ee5c738
heap-allocated root should be persistent
philippedistributive Feb 28, 2024
0af763c
Revert "chore(meta): update all top-of-file comments"
zollqir Feb 28, 2024
1276a9a
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Feb 28, 2024
889c912
remove unused second parameter to pyTypeFactory
philippedistributive Feb 28, 2024
4ba97f7
increment firefox version
philippedistributive Feb 28, 2024
4df71ee
version update
philippedistributive Feb 28, 2024
85dd1ee
chore(PyDictOrObjectProxyHandler): remove blank line
zollqir Feb 29, 2024
c4afd10
refactor(PyDictOrObjectProxyHandler): refactor the
zollqir Feb 29, 2024
edb9f69
chore(PyProxyHandlers): remove TODO comments about
zollqir Feb 29, 2024
61b2875
chore(tests): remove extra empty lines from
zollqir Feb 29, 2024
ba1afb8
use PersistentRooted pointer instead of inline in struct for Object a…
philippedistributive Feb 29, 2024
a0fea0c
chore(jsTypeFactory): remove extra blank lines from
zollqir Feb 29, 2024
ccbd1c5
chore(FinalizationRegistry): change
zollqir Feb 29, 2024
b4d33b4
feat(jsTypeFactory): correctly check the result of
zollqir Feb 29, 2024
30c120d
tp_name must be same as that of super type
philippedistributive Feb 29, 2024
f8a1217
finished details of JSObjectProxy.repr: skip over the $super key to a…
philippedistributive Feb 29, 2024
9733902
next version will be 0.4.0
philippedistributive Feb 29, 2024
4414c94
Merge branch 'main' into caleb/fix/this
philippedistributive Feb 29, 2024
1849dbf
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 1, 2024
c6b06a5
Merge branch 'main' into caleb/fix/this
philippedistributive Mar 1, 2024
ec03ef9
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 1, 2024
c4dc2bd
hash not implemented entry not required
philippedistributive Mar 1, 2024
40bdbb3
test fix
philippedistributive Mar 1, 2024
56e3af9
Merge branch 'main' into caleb/fix/this
philippedistributive Mar 4, 2024
4097f36
chore(PyObjectProxyHandler): don't use python C
zollqir Mar 4, 2024
9ba0e7e
Merge branch 'main' into caleb/fix/this
philippedistributive Mar 5, 2024
e9c6d1a
Merge branch 'main' into caleb/fix/this
philippedistributive Mar 5, 2024
0765086
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 5, 2024
7e7ed33
improved reference management
philippedistributive Mar 7, 2024
baab95f
dec ref needs to check for null
philippedistributive Mar 7, 2024
f8aafd8
feat(FinalizationRegistry): implement job queue
zollqir Mar 11, 2024
5ed221b
fix(pythonmonkey): delete the JobQueue & JSContext
zollqir Mar 11, 2024
cb92513
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 11, 2024
9764d1f
post-merge patch-up
philippedistributive Mar 11, 2024
dec4f72
Proxies now use parent type name for enhanced type compatibility
philippedistributive Mar 11, 2024
0e214c1
Merge branch 'main' into caleb/fix/this
philippedistributive Mar 11, 2024
a909fc7
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 11, 2024
0bd5c27
Merge branch 'main' into caleb/fix/this
philippedistributive Mar 13, 2024
bfc7798
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 13, 2024
c2d102d
cleanup and post-merge adjust
philippedistributive Mar 13, 2024
5fa62df
post-merge fixup
philippedistributive Mar 13, 2024
c645fca
include cleanup
philippedistributive Mar 13, 2024
a61ad04
Merge branch 'main' into caleb/fix/this
philippedistributive Mar 13, 2024
b986a4c
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 13, 2024
1c0670c
Merge branch 'main' into caleb/fix/this
philippedistributive Mar 14, 2024
9c0524f
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 14, 2024
8668e3d
refactor(PyBaseProxyHandler): remvoe PyDictOrObjectProxyHandler
zollqir Mar 14, 2024
8622867
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 14, 2024
bf16c39
enhanced python stack trace tests
philippedistributive Mar 14, 2024
7abbd1b
Revert "enhanced python stack trace tests"
philippedistributive Mar 14, 2024
f88cfd2
test fix
philippedistributive Mar 14, 2024
25f6134
Full JS stacks provided in the context of a Python Exception while ca…
philippedistributive Mar 14, 2024
7eaab5e
improved comment
philippedistributive Mar 14, 2024
93fb621
one more comment
philippedistributive Mar 14, 2024
015eb14
added test for array subclass
philippedistributive Mar 14, 2024
73f068a
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive Mar 14, 2024
b58b0ac
adjustment to __class__ implementation and added test
philippedistributive Mar 15, 2024
453ded4
Update src/ExceptionType.cc
philippedistributive Mar 15, 2024
327ab26
proper exception stack type
philippedistributive Mar 15, 2024
fbcb81c
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive Mar 15, 2024
703acad
Merge branch 'main' into caleb/fix/this
philippedistributive Mar 15, 2024
8dfaa43
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 15, 2024
993da0e
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive Mar 15, 2024
f72168e
Merge branch 'main' into caleb/fix/this
philippedistributive Mar 15, 2024
b52383c
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 15, 2024
cee3fb0
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive Mar 15, 2024
66dbb97
adjustment to __class__ for arrayproxy
philippedistributive Mar 15, 2024
501f26d
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive Mar 15, 2024
e08f74b
cleanup
philippedistributive Mar 15, 2024
9ddda1a
Merge branch 'main' into caleb/fix/this
philippedistributive Mar 15, 2024
20a47d4
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 15, 2024
8c7bce7
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive Mar 15, 2024
77f460b
Update src/jsTypeFactory.cc
philippedistributive Mar 15, 2024
c627e30
Revert "Update src/jsTypeFactory.cc"
philippedistributive Mar 15, 2024
f9c29ad
remove commented-out code
philippedistributive Mar 15, 2024
3cd6397
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive Mar 15, 2024
f44db82
Merge branch 'main' into caleb/fix/this
philippedistributive Mar 15, 2024
e08a1e7
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 15, 2024
76aa711
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive Mar 15, 2024
55265ae
Merge branch 'main' into caleb/fix/this
philippedistributive Mar 18, 2024
073972b
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 18, 2024
6d447c6
Merge branch 'philippe/pyTypeFactory-cleanup' into philippe/full-js-a…
philippedistributive Mar 18, 2024
e5a82e6
remove duplicate JS stack trace
philippedistributive Mar 19, 2024
da5f621
logic improvement
philippedistributive Mar 19, 2024
e8c439a
cleanup
philippedistributive Mar 19, 2024
0dc70af
logic improvement
philippedistributive Mar 19, 2024
9d737fd
newline not needed
philippedistributive Mar 19, 2024
93888de
Merge pull request #296 from Distributive-Network/philippe/full-js-an…
philippedistributive Mar 20, 2024
dd5e156
entry newline needed
philippedistributive Mar 20, 2024
c7e6a6c
Merge branch 'main' into caleb/fix/this
philippedistributive Mar 20, 2024
1adaabb
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 20, 2024
c544529
chore(CI): add core dumps to CI
zollqir Mar 20, 2024
1fff0de
Merge branch 'caleb/fix/this' of https://github.com/Distributive-Netw…
zollqir Mar 20, 2024
a2884c1
chore(CI): fix test-and-publish.yaml syntax error
zollqir Mar 20, 2024
27019d2
added get method test
philippedistributive Mar 20, 2024
86805ba
chore(CI): fix missing then in test-and-publish.yaml
zollqir Mar 20, 2024
df32a3c
allow object key to shadow method
philippedistributive Mar 20, 2024
1068741
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 20, 2024
78f9938
do distinguish between dict . and [] operators
philippedistributive Mar 20, 2024
c0a1af8
Merge branch 'philippe/pyTypeFactory-cleanup' of github.com:Distribut…
philippedistributive Mar 20, 2024
708a560
chore(CI): add tmate debugging to Actions runner
zollqir Mar 21, 2024
73e57c8
chore(CI): add -p flag to mkdir /cores
zollqir Mar 21, 2024
fd78561
chore(CI): upgrade deprecated actions
zollqir Mar 21, 2024
6c47748
chore(CI): add osname and python version to core dump
zollqir Mar 21, 2024
c69ea53
chore(CI): upgrade deprecated upload-artifact action
zollqir Mar 21, 2024
c2fdfa8
chore(CI): fix core dump names for Mac
zollqir Mar 21, 2024
1b444e0
chore(CI): name core dump artifact in Github Actions
zollqir Mar 21, 2024
b944db4
Revert "chore(CI): upgrade deprecated upload-artifact action"
zollqir Mar 21, 2024
96cb24d
chore(CI): fix core dump artifact name, only upload cores on failure
zollqir Mar 21, 2024
1e9ec27
chore(CI): run JS tests even if python tests fail
zollqir Mar 21, 2024
216545b
chore(CI): fix yaml syntax error
zollqir Mar 21, 2024
398baa8
chore(CI): add dump_cores input to CI workflow dispatch
zollqir Mar 21, 2024
ee8c33a
chore(CI): only set core names if cores will be dumped
zollqir Mar 21, 2024
3cb7ebc
no need for cpython GC compatibility for these
philippedistributive Mar 21, 2024
6452123
chore(meta): add logging of python libs during compilation
zollqir Mar 21, 2024
c54d5e8
Merge branch 'main' into caleb/fix/this
philippedistributive Mar 27, 2024
8aab622
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Mar 27, 2024
a2d818a
post-merge fixup
philippedistributive Mar 27, 2024
fba9c25
fix(JobQueue): allocate callbacks on the heap and delete global befor…
zollqir Apr 3, 2024
74ceb71
fix(JobQueue): don't double-free finalizationRegistryCallbacks vector
zollqir Apr 3, 2024
e77be01
Merge branch 'caleb/fix/this' into philippe/pyTypeFactory-cleanup
philippedistributive Apr 3, 2024
00dfec4
Merge pull request #234 from Distributive-Network/philippe/pyTypeFact…
philippedistributive Apr 3, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(CI): add osname and python version to core dump
  • Loading branch information
zollqir committed Mar 21, 2024
commit 6c477489b6e252fd0127f5cb230b6648daa8093c
8 changes: 6 additions & 2 deletions .github/workflows/test-and-publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,12 @@ jobs:
# TODO (Caleb Aikens) figure out how to get Windows core dumps
sudo mkdir -p /cores
sudo chmod 777 /cores
# Core filenames will be of the form executable.pid.timestamp:
sudo bash -c 'echo "/cores/%e.%p.%t" > /proc/sys/kernel/core_pattern'
# Core filenames will be of the form osname.pythonversion.executable.pid.timestamp:
if [[ "$OSTYPE" == "linux-gnu"* ]]; then
sudo bash -c 'echo "/cores/${OSTYPE}.$(poetry run python --version).%e.%p.%t" > /proc/sys/kernel/core_pattern'
else
sudo sysctl kernel.core_pattern="/cores/${OSTYPE}.$(poetry run python --version).%e.%p.%y"
fi
fi
- name: Run Python tests (pytest)
run: |
Expand Down
Loading