Skater as an Overlay (no more popup) #4

Ecalzo · 2020-08-16T23:48:22Z

This is a mostly-functioning version of Skater as a webpage overlay. This is being developed for the following reasons:

The extension is too slow as a standard chrome/FF popup. This is much much faster.
Being spotlight-inspired, this allows us to mimic the look/feel of Spotlight more closely

Core areas where I am looking for feedback:

How should I organize this? I have not figured out how to break this into multiple console scripts, but it may be simpler than I assume.
How should I test this thing? (kind of a TODO to learn about jest)
Being much faster, what else would you like this extension to be able to search through? Any thoughts on where else this can fit into a workflow?

…overlay.js content script

…en search Input not opened

background.js

overlay.js

wojm

stash

overlay.js

wojm

review

Ecalzo added 15 commits August 12, 2020 17:56

<WIP> adds a new div to a webpage

ca77718

feat: create and inject overlay div onto webpage

e6ab88e

new: use only content_script to create overlay

a525b4e

checkpointing progress

233d28c

new: working communication between background.js bookmark search and …

b004608

…overlay.js content script

chore: cleanup background.js

6dccf6a

fixes: creates input on webpage, populates ul with results dynamically

4f995ff

fix: append all new dom elements to overlayDiv

3fcdfe4

general css styling

f14f36d

checkpoint

83144e3

feat: rm border on search input, even on focus

f15d78c

new: centralize border and border-radius css around search container div

c072ee1

new: add opacity to search icon

57e52f5

new: remove overlayDiv by pressing Escape

fd693b5

search results list refinement

f9dd148

Ecalzo requested review from leedtan and edwinyung August 16, 2020 23:48

Ecalzo added 11 commits August 16, 2020 20:01

fix: ensure that the search window closes after the user presses Enter)

abaf038

wip: add todos for webpage/tab handling

40e1311

chore: move createListItem up to other create funcs

dde4036

poc: selection with down arrow key

501cc48

feat: traverse search results with arrow keys

ffdcefb

fix: make available on both http and https websites

982517c

chore: functionize moveUp and moveDown, handle event inputs errors wh…

d490177

…en search Input not opened

chore: functionize updateSearchResultsCSS

d300f62

chore: refactor moveDownOneResult

3f348bf

fix: use let to assign index outside of if else block

8c08a50

css: increase top to 25pc for search icon

34f6c6d

wojm reviewed Aug 17, 2020

View reviewed changes

background.js Outdated Show resolved Hide resolved

wojm reviewed Aug 17, 2020

View reviewed changes

overlay.js Outdated Show resolved Hide resolved

wojm reviewed Aug 20, 2020

View reviewed changes

overlay.js Outdated Show resolved Hide resolved

wojm reviewed Aug 20, 2020

View reviewed changes

overlay.js Outdated Show resolved Hide resolved

rm unused function in background.js

c229444

wojm reviewed Aug 20, 2020

View reviewed changes

overlay.js Outdated Show resolved Hide resolved

wojm reviewed Aug 20, 2020

View reviewed changes

Ecalzo added 21 commits August 21, 2020 19:50

manifest: use <all_urls>

73fe112

css: rm default styling from a tags

1992a76

js: reduce calls of preventDefault()

9e2078b

js: reduce return true statements

036c9f3

js: add Escape to if statement

a67e01a

html: change .focused to .skater-focused

4705a3b

js: use const instead of var

531c4f9

js: functionize getting the currently focused element

8dd0d4d

js: massively simplify moveDownOneResult

b2caa10

js: handle if you are trying to go down but are at the last list item

b8acd5e

js: rm returned undefined value from getSearchText

6a063ce

js: move edgecase handling to moveUpOneResult

aac71ce

chore: code formatting

c9f80a1

js: formatting

2047547

js: pass searchInput.value w/o intermediary variable

f4dc41c

js: rename func to stripIndexFromElementClass

792e37e

fix: undo rm of query variables

95223b0

js: rename updateSearchText

548422f

js: change activation key to cmd/ctrl + j

89cd3bf

css: set display: inline for search result icons

538e88c

js: change keydown trigger to j key

c75438c

Ecalzo merged commit 1c311d9 into master Aug 24, 2020

Ecalzo changed the title ~~WIP: Skater as an Overlay (no more popup)~~ Skater as an Overlay (no more popup) Aug 24, 2020

Ecalzo mentioned this pull request Aug 24, 2020

WIP: Firefox Support #3

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skater as an Overlay (no more popup) #4

Skater as an Overlay (no more popup) #4

Ecalzo commented Aug 16, 2020

wojm left a comment

wojm left a comment

Skater as an Overlay (no more popup) #4

Skater as an Overlay (no more popup) #4

Conversation

Ecalzo commented Aug 16, 2020

wojm left a comment

Choose a reason for hiding this comment

wojm left a comment

Choose a reason for hiding this comment