-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skater as an Overlay (no more popup) #4
Merged
Merged
Changes from 1 commit
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
ca77718
<WIP> adds a new div to a webpage
Ecalzo e6ab88e
feat: create and inject overlay div onto webpage
Ecalzo a525b4e
new: use only content_script to create overlay
Ecalzo 233d28c
checkpointing progress
Ecalzo b004608
new: working communication between background.js bookmark search and …
Ecalzo 6dccf6a
chore: cleanup background.js
Ecalzo 4f995ff
fixes: creates input on webpage, populates ul with results dynamically
Ecalzo 3fcdfe4
fix: append all new dom elements to overlayDiv
Ecalzo f14f36d
general css styling
Ecalzo 83144e3
checkpoint
Ecalzo f15d78c
feat: rm border on search input, even on focus
Ecalzo c072ee1
new: centralize border and border-radius css around search container div
Ecalzo 57e52f5
new: add opacity to search icon
Ecalzo fd693b5
new: remove overlayDiv by pressing Escape
Ecalzo f9dd148
search results list refinement
Ecalzo abaf038
fix: ensure that the search window closes after the user presses Enter)
Ecalzo 40e1311
wip: add todos for webpage/tab handling
Ecalzo dde4036
chore: move createListItem up to other create funcs
Ecalzo 501cc48
poc: selection with down arrow key
Ecalzo ffdcefb
feat: traverse search results with arrow keys
Ecalzo 982517c
fix: make available on both http and https websites
Ecalzo d490177
chore: functionize moveUp and moveDown, handle event inputs errors wh…
Ecalzo d300f62
chore: functionize updateSearchResultsCSS
Ecalzo 3f348bf
chore: refactor moveDownOneResult
Ecalzo 8c08a50
fix: use let to assign index outside of if else block
Ecalzo 34f6c6d
css: increase top to 25pc for search icon
Ecalzo 4347017
Include favicons in search results
Ecalzo 436dc59
better css selections
Ecalzo ab1be7a
better padding for search results
Ecalzo bcd6fef
fix: preventDefault() prevents page from scrolling
Ecalzo bfd7d08
more FIXMEs
Ecalzo 4ba4e20
change opacity for highlighted search result
Ecalzo 2811541
css: first result is always highlighted, css tweaks
Ecalzo 1ee543d
increase padding size on searchWrapperDiv
Ecalzo b64cf4b
css: improve box shadow
Ecalzo 19d850b
css: animations for search result focus
Ecalzo a806fbb
chore: rm commented lines
Ecalzo 799ea1c
fix: add boolean to array check
Ecalzo cab186f
css: rm border from focused element
Ecalzo 6515d86
rm unused lines
Ecalzo 104d019
fix: separate input event listener into a main function
Ecalzo 8c6a5af
chore: rename main to setUpInputEventListener
Ecalzo 722c4c1
chore: delete unused code
Ecalzo 4affb72
rm whitespace
Ecalzo 1a24642
css: border-radius and better infill for focused search result
Ecalzo 3423792
css: refine searchIcon
Ecalzo d65ca11
css: more tweaks
Ecalzo ca16391
use setTimeout to animate the first result
Ecalzo e549a01
css: fix input element overflow by using px
Ecalzo 0ce0afa
css: reduce padding for search wrapper div
Ecalzo c31a29b
css: recenter search icon
Ecalzo 2bc350e
css: update left property of search icon
Ecalzo 84a19a9
rm fake function
Ecalzo bcd89dc
fix: new settimeout func, increase delays
Ecalzo 4df158b
css: reduce ease time, favicon margins
Ecalzo 1a6fe05
css: margin-bottom for favicon
Ecalzo 8e583d4
js: reduce setTimeout to 100ms for focusInput
Ecalzo 47092d4
js: check for valid input keys before triggering expensive update fun…
Ecalzo abe79b1
js: handle arrow key errors
Ecalzo 0ec5c5e
css: use skate to..., icon css tweaks
Ecalzo 590aee7
refactor: never unfocus input, use new focus class as indicator for h…
Ecalzo 9a481df
rm unused files
Ecalzo 9c26639
use z-index to hoist overlay div to top of the page
Ecalzo 252a1e2
css: increase z-index
Ecalzo 7c337ba
feat: prevent opening infinite number of windows
Ecalzo a2570fd
use shift key to open
Ecalzo 1e6d070
auto refocus
Ecalzo c229444
rm unused function in background.js
Ecalzo 73fe112
manifest: use <all_urls>
Ecalzo 1992a76
css: rm default styling from a tags
Ecalzo 9e2078b
js: reduce calls of preventDefault()
Ecalzo 036c9f3
js: reduce return true statements
Ecalzo a67e01a
js: add Escape to if statement
Ecalzo 4705a3b
html: change .focused to .skater-focused
Ecalzo 531c4f9
js: use const instead of var
Ecalzo 8dd0d4d
js: functionize getting the currently focused element
Ecalzo b2caa10
js: massively simplify moveDownOneResult
Ecalzo b8acd5e
js: handle if you are trying to go down but are at the last list item
Ecalzo 6a063ce
js: rm returned undefined value from getSearchText
Ecalzo aac71ce
js: move edgecase handling to moveUpOneResult
Ecalzo c9f80a1
chore: code formatting
Ecalzo 2047547
js: formatting
Ecalzo f4dc41c
js: pass searchInput.value w/o intermediary variable
Ecalzo 792e37e
js: rename func to stripIndexFromElementClass
Ecalzo 95223b0
fix: undo rm of query variables
Ecalzo 548422f
js: rename updateSearchText
Ecalzo 89cd3bf
js: change activation key to cmd/ctrl + j
Ecalzo 538e88c
css: set display: inline for search result icons
Ecalzo c75438c
js: change keydown trigger to j key
Ecalzo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
new: remove overlayDiv by pressing Escape
- Loading branch information
commit fd693b5ed10968036a643f34700c29096029afa5
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this if block should be in the func and return the index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also the only diff between these two functions is the +1 vs -1