fix: prevent crash if there is error when executing

KamiGim · Oct 17, 2018 · d578fd0 · d578fd0
1 parent ba73b69
commit d578fd0
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/src/ts/executors/custom-command-executor.ts b/src/ts/executors/custom-command-executor.ts
@@ -3,6 +3,7 @@ import { Executor } from "./executor";
 import { CommandLineExecutionArgumentValidator } from "../execution-argument-validators/command-line-execution-argument-validator";
 import { UeliHelpers } from "../helpers/ueli-helpers";
 import { exec } from "child_process";
+import { dialog } from "electron";
 
 export class CustomCommandExecutor implements Executor {
     public hideAfterExecution = true;
@@ -25,7 +26,7 @@ export class CustomCommandExecutor implements Executor {
         this.hideAfterExecution = true;
         exec(executionArgument, (err: Error): void => {
             if (err) {
-                throw err;
+                dialog.showErrorBox("Execute file/folde path", err.stack || err.message);
             }
         });
     }

diff --git a/src/ts/executors/file-path-executor.ts b/src/ts/executors/file-path-executor.ts
@@ -50,7 +50,7 @@ export class FilePathExecutor implements Executor {
     private handleAlternativeExecuteDir(filePath: string) {
         childProcess.exec(`"${this.textEditorPath}" "${filePath}"`, (err) => {
             if (err) {
-                throw err;
+                dialog.showErrorBox("Execute file/folde path", err.stack || err.message);
             }
         });
     }

diff --git a/src/ts/executors/web-search-executor.ts b/src/ts/executors/web-search-executor.ts
@@ -4,6 +4,7 @@ import { Executor } from "./executor";
 import { platform } from "os";
 import { WebSearchHelpers } from "../helpers/web-search-helper";
 import { WebSearch } from "../web-search";
+import { dialog } from "electron";
 
 export class WebSearchExecutor implements Executor {
     public readonly hideAfterExecution = true;
@@ -22,7 +23,7 @@ export class WebSearchExecutor implements Executor {
                 const command = Injector.getOpenUrlWithDefaultBrowserCommand(platform(), executionArgument);
                 exec(command, (err) => {
                     if (err) {
-                        throw err;
+                        dialog.showErrorBox("Execute file/folde path", err.stack || err.message);
                     }
                 });
             }

diff --git a/src/ts/executors/web-url-executor.ts b/src/ts/executors/web-url-executor.ts
@@ -2,6 +2,7 @@ import { Executor } from "./executor";
 import { Injector } from "../injector";
 import { exec } from "child_process";
 import { platform } from "os";
+import { dialog } from "electron";
 
 export class WebUrlExecutor implements Executor {
     public readonly hideAfterExecution = true;
@@ -16,7 +17,7 @@ export class WebUrlExecutor implements Executor {
     private handleCommandExecution(command: string): void {
         exec(command, (err) => {
             if (err) {
-                throw err;
+                dialog.showErrorBox("Execute file/folde path", err.stack || err.message);
             }
         });
     }

diff --git a/src/ts/executors/windows-settings-executor.ts b/src/ts/executors/windows-settings-executor.ts
@@ -1,6 +1,7 @@
 import { exec } from "child_process";
 import { Executor } from "./executor";
 import { WindowsSettingsHelpers } from "../helpers/windows-settings-helpers";
+import { dialog } from "electron";
 
 export class WindowsSettingsExecutor implements Executor {
     public readonly hideAfterExecution = true;
@@ -12,7 +13,7 @@ export class WindowsSettingsExecutor implements Executor {
 
         exec(`start ${command}`, (err): void => {
             if (err) {
-                throw err;
+                dialog.showErrorBox("Execute file/folde path", err.stack || err.message);
             }
         });
     }