Skip to content

689 add raytracerview config - RAYTRACER_FORMAT #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 689-add_raytracerview_config
Choose a base branch
from

Conversation

SandroReith
Copy link

Issue #699

Add a description

Reformatted to utilize the ray tracing approach
Offers a generic description, independent of tool provider or sensor technology

Some questions to ask:
What is this change?
Format of the Raytracing View.
Content of the Raytracing View
Name of the enum

What does it fix?
Reduces dependency on specific tools and technologies
Facilitates standardization and unification

How has it been tested?
proposal

Reformatted to utilize the ray tracing approach. Offers a generic description, independent of tool provider or sensor technology


Signed-off-by: SandroReith <[email protected]>
updated enum for RAYTRACER_FORMAT_SBR 3 -> 2

Signed-off-by: SandroReith <[email protected]>
Copy link
Contributor

@thomassedlmayer thomassedlmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SandroReith: Maybe we could already merge this PR into the other PR (#699) and continue working there?

Another topic: Since this is about the unambiguous specification of a binary format, isn't it necessary to also specify the float size/precision. endianness and vector/matrix value order?

//
RAYTRACER_FORMAT_VIVALDI_RADAR = 3;
RAYTRACER_FORMAT_SBR = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensor Modeling Group (11.06.): Discussion about additional format type including the field "bounce depth" -> Add it only as additional/optional pull request. @SandroReith Do you want this other format to be included as well? What would be a good name for it?

// direction_of_departure_azimuth (float; in rad; direction of departure of the ray in the configured raytracer coordinate system in azimuth direction)
// direction_of_departure_elevation (float; in rad; direction of departure of the ray in the configured raytracer coordinate system in elevation direction)
//
RAYTRACER_FORMAT_DIVP_RADAR = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensor Modeling Group (11.06.): Agree to remove DIVP type for now. Inclusion of the DIVP format depends on someone involved in the DIVP project and working with this format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants