-
Notifications
You must be signed in to change notification settings - Fork 131
689 add raytracerview config - RAYTRACER_FORMAT #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SandroReith
wants to merge
2
commits into
OpenSimulationInterface:689-add_raytracerview_config
Choose a base branch
from
SandroReith:689-add_raytracerview_config
base: 689-add_raytracerview_config
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1088,33 +1088,19 @@ message RaytracerViewConfiguration | |
// Consider proposing an additional format if using | ||
// \c #RAYTRACER_FORMAT_OTHER. | ||
// | ||
RAYTRACER_FORMAT_OTHER = 1; | ||
RAYTRACER_FORMAT_OTHER = 1; | ||
|
||
// Radar raytracer format used in the Japanese DIVP project. | ||
// | ||
// The message consists of the following fields in the described order. | ||
// In brackets the data type, the unit and a short description is given. | ||
// distance (float; in m; path length of the ray) | ||
// relative_speed (float; in m/s; summed relative speed due to interaction points with moved surfaces) | ||
// propagation_attenuation_h_pol (float; in W; attenuation of signal strength of horizontal polarisation) | ||
// propagation_attenuation_v_pol (float; in W; attenuation of signal strength of vertical polarisation) | ||
// direction_of_arrival_azimuth (float; in rad; direction of arrival of the ray in the configured raytracer coordinate system in azimuth direction) | ||
// direction_of_arrival_elevation (float; in rad; direction of arrival of the ray in the configured raytracer coordinate system in elevation direction) | ||
// direction_of_departure_azimuth (float; in rad; direction of departure of the ray in the configured raytracer coordinate system in azimuth direction) | ||
// direction_of_departure_elevation (float; in rad; direction of departure of the ray in the configured raytracer coordinate system in elevation direction) | ||
// | ||
RAYTRACER_FORMAT_DIVP_RADAR = 2; | ||
|
||
// Radar raytracer format used in the German VIVALDI project. | ||
// Raytracer format for Shoot and Bounce Approach | ||
// Adapted for electromagnetic wave propagation | ||
// | ||
// The message consists of the following fields in the described order. | ||
// In brackets the data type, the unit and a short description is given. | ||
// intersection_path_length (float; in m; path length of the ray between the First_Hitpoint and the Last_Hitpoint) | ||
// relative_speed (float; in m/s; summed relative speed due to interaction points with moved surfaces) | ||
// jones_vector (float4; in V/m; jones vector of the ray with information of the electromagnetic wave`s phase, signal strength and polarisation) | ||
// last_hitpoint (float3; in m; coordinates of the last hitpoint in the raytracer's coordinate system defined by the mounting position) | ||
// first_hitpoint (float3; in m; coordinates of the first hitpoint in the raytracer's coordinate system defined by the mounting position) | ||
// jones_matrices (float8; in V/m; jones matrix of the ray with information of the electromagnetic wave`s phase, signal strength and polarisation, which gives you additonaly the projection to the subset of the jones vectors ) | ||
// direction_of_arrival_hitpoint (float3; in m; coordinates of the DoA (last hitpoint) in the raytracer's coordinate system defined by the mounting position) | ||
// direction_of_departure_hitpoint (float3; in m; coordinates of the DoD (first hitpoint) in the raytracer's coordinate system defined by the mounting position) | ||
// | ||
RAYTRACER_FORMAT_VIVALDI_RADAR = 3; | ||
RAYTRACER_FORMAT_SBR = 2; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sensor Modeling Group (11.06.): Discussion about additional format type including the field "bounce depth" -> Add it only as additional/optional pull request. @SandroReith Do you want this other format to be included as well? What would be a good name for it? |
||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sensor Modeling Group (11.06.): Agree to remove DIVP type for now. Inclusion of the DIVP format depends on someone involved in the DIVP project and working with this format.