Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solver2x2 does not work with active media #130

Closed
MarJMue opened this issue Apr 16, 2023 · 4 comments · Fixed by #136
Closed

Solver2x2 does not work with active media #130

MarJMue opened this issue Apr 16, 2023 · 4 comments · Fixed by #136

Comments

@MarJMue
Copy link
Collaborator

MarJMue commented Apr 16, 2023

As explained in Byrnes' Paper (appendices C and D) the fresnel method can not handle active media that exhibit gain.

We should either check the inputs or give at least a warning if n>0 and k<0.

@domna
Copy link
Member

domna commented Apr 16, 2023

I see. Thank you for researching this!

I think we can just show a warning or even raise an exception for this case. We should then refer to the Solver4x4, because I assume that it can handle gain correctly, right?

@MarJMue
Copy link
Collaborator Author

MarJMue commented Apr 16, 2023

As far as i can tell 4x4 should work with active media, until the algorithm breaks down due to overflow errors.

@domna
Copy link
Member

domna commented Apr 16, 2023

Ok, then I would say that Solver2x2 is just not suitable for gain media and we should let it fail for negative k and refer to Solver4x4. Agreed?

@MarJMue
Copy link
Collaborator Author

MarJMue commented Apr 16, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants