Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-navigation-layout): replace "sideCollapsed" property with "mode" property #10390

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

fix(ui5-navigation-layout): replace "sideCollapsed" property with "mode" property #10390

wants to merge 20 commits into from

Conversation

TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented Dec 16, 2024 •
edited
Loading

BGSOFUIRODOPI-3377

@TeodorTaushanov TeodorTaushanov changed the title fix(ui5-navigation-layout): fix sideCollapsed property fix(ui5-navigation-layout): rename sideCollapsed property to "mode" Dec 17, 2024
@TeodorTaushanov TeodorTaushanov changed the title fix(ui5-navigation-layout): rename sideCollapsed property to "mode" fix(ui5-navigation-layout): remove "sideCollapsed" property and add "mode" property Dec 17, 2024
Stoev
Stoev reviewed Dec 17, 2024
View reviewed changes
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider changing the header:

fix(ui5-navigation-layout): replace "sideCollapsed" property with "mode" property

@TeodorTaushanov TeodorTaushanov changed the title fix(ui5-navigation-layout): remove "sideCollapsed" property and add "mode" property fix(ui5-navigation-layout): replace "sideCollapsed" property with "mode" property Dec 18, 2024
Stoev
Stoev reviewed Dec 18, 2024
View reviewed changes
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK from UA perspective.

alexandar-mitsev
alexandar-mitsev requested changes Dec 19, 2024
View reviewed changes
packages/fiori/src/NavigationLayout.ts Outdated Show resolved Hide resolved
packages/fiori/src/NavigationLayout.ts Show resolved Hide resolved
packages/fiori/src/NavigationLayout.ts Outdated Show resolved Hide resolved
@TeodorTaushanov TeodorTaushanov requested a review from a team December 20, 2024 13:01
@TeodorTaushanov TeodorTaushanov changed the title fix(ui5-navigation-layout): replace "sideCollapsed" property with "mode" property fix(ui5-navigation-layout): add new "mode" property Dec 20, 2024
@TeodorTaushanov TeodorTaushanov changed the title fix(ui5-navigation-layout): add new "mode" property fix(ui5-navigation-layout): replace "sideCollapsed" property with "mode" property Dec 20, 2024
Stoev
Stoev reviewed Dec 20, 2024
View reviewed changes
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK from my perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stoev Stoev Stoev left review comments

@alexandar-mitsev alexandar-mitsev alexandar-mitsev requested changes

@pskelin pskelin Awaiting requested review from pskelin

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeodorTaushanov @alexandar-mitsev @Stoev