Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-navigation-layout): replace "sideCollapsed" property with "mode" property #10390

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
+67 −33
Open

fix(ui5-navigation-layout): replace "sideCollapsed" property with "mode" property #10390

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
8a9825c
fix(ui5-navigation-layout): change side-collapsed property
TeodorTaushanov Dec 13, 2024
96291cc
Merge remote-tracking branch 'origin/main' into navigation_layout_col…
TeodorTaushanov Dec 13, 2024
c50ee4a
Merge remote-tracking branch 'origin/main' into navigation_layout_col…
TeodorTaushanov Dec 13, 2024
ee5cc4b
chore: add private actualSideCollapsed
TeodorTaushanov Dec 13, 2024
9a795a7
Merge remote-tracking branch 'origin/main' into navigation_layout_col…
TeodorTaushanov Dec 16, 2024
bae7110
chore: use "effective" word
TeodorTaushanov Dec 16, 2024
1179afb
Merge remote-tracking branch 'origin/main' into navigation_layout_col…
TeodorTaushanov Dec 16, 2024
ddaf4a9
chore: fix lint error
TeodorTaushanov Dec 16, 2024
4d24a77
chore: fix lint error and docs
TeodorTaushanov Dec 16, 2024
30d2560
Merge remote-tracking branch 'origin/main' into navigation_layout_col…
TeodorTaushanov Dec 17, 2024
b351294
chore: rename the property and the enum
TeodorTaushanov Dec 17, 2024
2bcc158
chore: fix css
TeodorTaushanov Dec 17, 2024
c61e57a
chore: remove custom setter
TeodorTaushanov Dec 17, 2024
ecf744f
chore: fix docs
TeodorTaushanov Dec 17, 2024
b731654
Merge remote-tracking branch 'origin/main' into navigation_layout_col…
TeodorTaushanov Dec 17, 2024
0842c70
chore: fix docs
TeodorTaushanov Dec 17, 2024
bb87ca0
Merge remote-tracking branch 'origin/main' into navigation_layout_col…
TeodorTaushanov Dec 20, 2024
9a80680
chore: adress code comments
TeodorTaushanov Dec 20, 2024
f0964f8
Merge remote-tracking branch 'origin/main' into navigation_layout_col…
TeodorTaushanov Dec 20, 2024
abb1b76
chore: fix test
TeodorTaushanov Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix docs
  • Loading branch information
@TeodorTaushanov
TeodorTaushanov committed Dec 17, 2024
commit ecf744f9987ad9635a803eea62bcad19cd2090c1
2 changes: 1 addition & 1 deletion packages/fiori/src/NavigationLayout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class NavigationLayout extends UI5Element {
_defaultMode = isPhone() || (isTablet() && !isCombi());

/**
* Specifies the side navigation mode.
* Specifies the navigation mode.
* @default NavigationLayoutCollapsed.Auto
* @public
*/
Expand Down
Loading