-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename PartnersURLs to ApplicationURLs #5244
Merged
isaacroldan
merged 1 commit into
main
from
01-21-rename_partnersurls_to_applicationurls
Jan 27, 2025
Merged
Rename PartnersURLs to ApplicationURLs #5244
isaacroldan
merged 1 commit into
main
from
01-21-rename_partnersurls_to_applicationurls
Jan 27, 2025
+30
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 21, 2025
Coverage report
Show files with reduced coverage 🔻
Test suite run success2005 tests passing in 905 suites. Report generated by 🧪jest coverage report action from 546e633 |
We detected some changes at packages/*/src and there are no updates in the .changeset. |
craigmichaelmartin
approved these changes
Jan 21, 2025
isaacroldan
force-pushed
the
01-21-rename_partnersurls_to_applicationurls
branch
from
January 21, 2025 16:35
8e1b613
to
d905f26
Compare
3 tasks
isaacroldan
force-pushed
the
01-21-rename_partnersurls_to_applicationurls
branch
from
January 24, 2025 10:15
d905f26
to
546e633
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Just because it makes more sense to call it
ApplicationURLs
thanPartnersURLs
WHAT is this pull request doing?
PartnersURLs
interface toApplicationURLs
generatePartnersURLs
function togenerateApplicationURLs
validatePartnersURLs
function tovalidateApplicationURLs
How to test your changes?
Measuring impact
Checklist