-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prompt message and tests #5255
base: 01-21-stop_updating_the_app_urls_in_the_app_toml_when_using_the_app_management_api
Are you sure you want to change the base?
Update prompt message and tests #5255
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
We detected some changes at packages/*/src and there are no updates in the .changeset. |
14732be
to
5dfd581
Compare
7edb80f
to
3ab60f3
Compare
Coverage report
Test suite run success2047 tests passing in 913 suites. Report generated by 🧪jest coverage report action from 4c4265d |
5dfd581
to
d403209
Compare
3ab60f3
to
a0b2a35
Compare
d403209
to
de7a5e4
Compare
a0b2a35
to
42e1e85
Compare
de7a5e4
to
924baa2
Compare
42e1e85
to
12e63a8
Compare
924baa2
to
343f9cf
Compare
12e63a8
to
cf6d156
Compare
This reverts commit 2688080.
343f9cf
to
e75e2d6
Compare
cf6d156
to
4c4265d
Compare
WHY are these changes introduced?
Adds a new prompt for "url updates during dev" adapted to dev sessions context.
WHAT is this pull request doing?
How to test your changes?
Start with an app without
automatically_update_urls_on_dev
in its config.app dev
with dev sessions enabled and verify the new prompt appearsautomatically_update_urls_on_dev
and when using dev sessions, the URLs are NOT updated in the toml.Measuring impact
Checklist