Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prompt message and tests #5255

Open
wants to merge 5 commits into
base: 01-21-stop_updating_the_app_urls_in_the_app_toml_when_using_the_app_management_api
Choose a base branch
from

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Jan 22, 2025

WHY are these changes introduced?

Adds a new prompt for "url updates during dev" adapted to dev sessions context.

WHAT is this pull request doing?

  • Introduces a new dev sessions-specific prompt that clearly indicates URL changes only affect the dev store
  • Updates the prompt messaging to be more explicit about which configurations are affected

How to test your changes?

Start with an app without automatically_update_urls_on_dev in its config.

  1. Run app dev with dev sessions enabled and verify the new prompt appears
  2. Verify legacy prompt still appears when dev sessions are disabled
  3. Confirm toml is updated with automatically_update_urls_on_dev and when using dev sessions, the URLs are NOT updated in the toml.

Measuring impact

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Sorry, something went wrong.

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@isaacroldan isaacroldan marked this pull request as ready for review January 22, 2025 17:10
@isaacroldan isaacroldan requested a review from a team as a code owner January 22, 2025 17:10
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@isaacroldan isaacroldan force-pushed the 01-21-stop_updating_the_app_urls_in_the_app_toml_when_using_the_app_management_api branch from 14732be to 5dfd581 Compare January 24, 2025 10:15
@isaacroldan isaacroldan force-pushed the 01-22-add_new_update-urls_prompt_for_dev-sessions branch 3 times, most recently from 7edb80f to 3ab60f3 Compare January 24, 2025 10:31
Copy link
Contributor

github-actions bot commented Jan 24, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.6% (+0.06% 🔼)
9062/11987
🟡 Branches
70.85% (+0.07% 🔼)
4428/6250
🟡 Functions
75.44% (+0.06% 🔼)
2380/3155
🟡 Lines
76.13% (+0.06% 🔼)
8559/11243

Test suite run success

2047 tests passing in 913 suites.

Report generated by 🧪jest coverage report action from 4c4265d

@isaacroldan isaacroldan force-pushed the 01-21-stop_updating_the_app_urls_in_the_app_toml_when_using_the_app_management_api branch from 5dfd581 to d403209 Compare January 28, 2025 15:02
@isaacroldan isaacroldan force-pushed the 01-22-add_new_update-urls_prompt_for_dev-sessions branch from 3ab60f3 to a0b2a35 Compare January 28, 2025 15:02
@isaacroldan isaacroldan force-pushed the 01-21-stop_updating_the_app_urls_in_the_app_toml_when_using_the_app_management_api branch from d403209 to de7a5e4 Compare February 4, 2025 13:00
@isaacroldan isaacroldan force-pushed the 01-22-add_new_update-urls_prompt_for_dev-sessions branch from a0b2a35 to 42e1e85 Compare February 4, 2025 13:01
@isaacroldan isaacroldan force-pushed the 01-21-stop_updating_the_app_urls_in_the_app_toml_when_using_the_app_management_api branch from de7a5e4 to 924baa2 Compare February 4, 2025 16:14
@isaacroldan isaacroldan force-pushed the 01-22-add_new_update-urls_prompt_for_dev-sessions branch from 42e1e85 to 12e63a8 Compare February 4, 2025 16:15
@isaacroldan isaacroldan force-pushed the 01-21-stop_updating_the_app_urls_in_the_app_toml_when_using_the_app_management_api branch from 924baa2 to 343f9cf Compare February 4, 2025 16:29
@isaacroldan isaacroldan force-pushed the 01-22-add_new_update-urls_prompt_for_dev-sessions branch from 12e63a8 to cf6d156 Compare February 4, 2025 16:29
@isaacroldan isaacroldan force-pushed the 01-21-stop_updating_the_app_urls_in_the_app_toml_when_using_the_app_management_api branch from 343f9cf to e75e2d6 Compare February 7, 2025 17:18
@isaacroldan isaacroldan force-pushed the 01-22-add_new_update-urls_prompt_for_dev-sessions branch from cf6d156 to 4c4265d Compare February 7, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants