Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow to deprecate more old packages in NPM #5257

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Jan 23, 2025

WHY are these changes introduced?

We want to deprecate @shopify/shopify-cli-extensions and @shopify/ngrok in NPM.

WHAT is this pull request doing?

Adds a one-time GitHub action to deprecate the packages in NPM, by using the npm deprecate command.

That will include a warning in the NPM website and the command line when installing them: https://docs.npmjs.com/using-deprecated-packages

It can be reversed.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@gonzaloriestra gonzaloriestra requested a review from a team as a code owner January 23, 2025 08:25
Copy link
Contributor

github-actions bot commented Jan 23, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.33% 8890/11801
🟡 Branches
70.58% (+0.02% 🔼)
4323/6125
🟡 Functions 75.1% 2337/3112
🟡 Lines
75.87% (+0.01% 🔼)
8402/11074
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% 90.48% 98.61%

Test suite run success

2001 tests passing in 904 suites.

Report generated by 🧪jest coverage report action from 34895ce

@gonzaloriestra gonzaloriestra force-pushed the deprecate-shopify-cli-extensions branch from ee2dfa5 to bc84c2d Compare January 23, 2025 10:03
@shopify-shipit shopify-shipit bot deployed to experimental January 23, 2025 10:04 Active
@gonzaloriestra gonzaloriestra force-pushed the deprecate-shopify-cli-extensions branch from bc84c2d to d74700a Compare January 23, 2025 10:05
@gonzaloriestra gonzaloriestra force-pushed the deprecate-shopify-cli-extensions branch from d74700a to 34895ce Compare January 23, 2025 10:07
@gonzaloriestra gonzaloriestra changed the title Workflow to deprecate shopify-cli-extensions in NPM Workflow to deprecate more old packages in NPM Jan 23, 2025
Copy link
Contributor Author

gonzaloriestra commented Jan 23, 2025

Merge activity

  • Jan 23, 6:16 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 23, 6:17 AM EST: A user added this pull request to the GitHub merge queue with Graphite.

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit ea0cc7c Jan 23, 2025
26 checks passed
@gonzaloriestra gonzaloriestra deleted the deprecate-shopify-cli-extensions branch January 23, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants