Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor comment #3181

Merged
merged 14 commits into from
Feb 9, 2025
Merged

Editor comment #3181

merged 14 commits into from
Feb 9, 2025

Conversation

MatusGuy
Copy link
Member

The editor comment allows level designers to leave a note for themselves or other level designers collaborating on the same level. Similar to a code comment, it can be used to write to-do lists, fixmes, or notes.

This feature supports info box formatting, like what you'd see in the info block or the text scroller.

Testers: Please test all formatting features in the editor comment (of course), the info block, and the text scroller (via credits, I guess).
Use this as a reference for all formatting features:

InfoBoxLine::LineType get_linetype_by_format_char(char format_char) {
switch (format_char)
{
case ' ':
return InfoBoxLine::SMALL;
case '\t':
return InfoBoxLine::NORMAL;
case '-':
return InfoBoxLine::HEADING;
case '*':
return InfoBoxLine::REFERENCE;
case '#':
return InfoBoxLine::NORMAL_LEFT;
case '!':
return InfoBoxLine::IMAGE;
default:
return InfoBoxLine::SMALL;
//log_warning << "Unknown format_char: '" << format_char << "'" << std::endl;
}
}

@Alasdairbugs Alasdairbugs self-requested a review January 18, 2025 16:24
@Alasdairbugs
Copy link
Contributor

image

i get missing texture for the icon in the thingy

@MatusGuy
Copy link
Member Author

fixed

Copy link
Member

@Vankata453 Vankata453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test it tomorrow.

src/editor/editor_comment.cpp Show resolved Hide resolved
src/editor/editor_comment.cpp Outdated Show resolved Hide resolved
src/editor/editor_comment.cpp Outdated Show resolved Hide resolved
src/editor/editor_comment.hpp Outdated Show resolved Hide resolved
src/editor/editor_comment.hpp Show resolved Hide resolved
src/editor/editor_comment.hpp Outdated Show resolved Hide resolved
src/editor/editor_comment.hpp Show resolved Hide resolved
when i play 50 cent i push the airpods deeper in my ear
when i play 50 cent i imagine all my dogs are right here

maybe theyre in heaven smoking weed with the bros
maybe heaven's that feeling when you first hit that pose

because i know im not going to that heaven with my gamertag
@MatusGuy MatusGuy merged commit 40f45f6 into SuperTux:master Feb 9, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants