-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Admin::Accounts methods #404
Add Admin::Accounts methods #404
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #404 +/- ##
============================================
- Coverage 50.01% 49.84% -0.17%
- Complexity 620 661 +41
============================================
Files 155 162 +7
Lines 4243 4484 +241
Branches 269 284 +15
============================================
+ Hits 2122 2235 +113
- Misses 1885 1996 +111
- Partials 236 253 +17
|
7455c1f
to
e051183
Compare
bigbone-rx/src/main/kotlin/social/bigbone/rx/admin/RxAdminAccountMethods.kt
Show resolved
Hide resolved
e051183
to
c6e765d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, I'm fine with everything you highlighted via comment.
I'm a bit short on time, so I didn't check the new assets in detail, but assume that those were just copied from available examples and are OK.
Would it be possible to refactor the apiName definition in the enums somehow, so that we don't have to repeat them that often? Doesn't need to happen in this PR, of course, but if at all possible, a new issue could be opened for that.
Description
This PR implements the methods available via the Admin::Accounts endpoints. Despite the branch saying
part-1
, this actually implements all of them. After having started, I no longer even checked which ones were part of the ticket.Warning
I have not implemented the v1 variant as it’s due for removal next year anyway.
Note
Mastodon API documentation examples still contain
ip
as an object instead of a String. I have decided to implementAdminAccount
by how it’s defined in the Admin::Account documentation instead.Closes #323, closes #324.
Type of Change
Breaking Changes
How Has This Been Tested?
New unit tests for all methods added including their optional parameter variants
Mandatory Checklist
gradle check
and there were no errors reportedOptional checks
*Methods
classes: Did you also reference it in theMastodonClient
main class?/docs
folder (e.g. API Coverage page)?