Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully implement partially implemented AccountMethods #411

Merged
merged 15 commits into from
Dec 30, 2023

Conversation

PattaFeuFeu
Copy link
Collaborator

@PattaFeuFeu PattaFeuFeu commented Dec 28, 2023

Description

This PR is part 1 for #405 and implements missing properties and entity parameters. No new methods will be added in this PR—that’ll be the task for a follow-up PR.

Type of Change

  • New feature
  • Documentation

Breaking Changes

  • AccountMethods#verifyCredentials now returns CredentialAccount instead of Account
  • AccountMethods#updateCredentials now returns CredentialAccount instead of Account
  • AccountMethods#updateCredentials got a few new parameters. As none of them are optional, this will break existing calls, but they can easily be added.
  • AccountMethods#getStatuses gained two now parameters excludeReblogs and filterByTaggedWith. Both are optional, like many existing parameters, but they are intertwined with other parameters. So if you use Java, or used Kotlin without named parameters here, your calls will likely or may return wrong results if you supply a Boolean to the wrong field.

How Has This Been Tested?

New unit tests and updates for existing unit tests

Mandatory Checklist

  • I ran gradle check and there were no errors reported
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • I have added KDoc documentation to all public methods

@PattaFeuFeu PattaFeuFeu added the blocked Blocked by another issue or PR label Dec 28, 2023
@PattaFeuFeu PattaFeuFeu self-assigned this Dec 28, 2023
@PattaFeuFeu PattaFeuFeu added documentation Improvements or additions to documentation or sample code enhancement New feature or request labels Dec 28, 2023
@PattaFeuFeu PattaFeuFeu changed the title Enhancement/405 accounts api Fully implement partially implemented AccountMethods Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 154 lines in your changes are missing coverage. Please review.

Comparison is base (cf71753) 49.84% compared to head (b6557c1) 49.25%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #411      +/-   ##
============================================
- Coverage     49.84%   49.25%   -0.60%     
- Complexity      683      714      +31     
============================================
  Files           168      169       +1     
  Lines          4570     4769     +199     
  Branches        284      312      +28     
============================================
+ Hits           2278     2349      +71     
- Misses         2037     2157     +120     
- Partials        255      263       +8     
Files Coverage Δ
...c/main/kotlin/social/bigbone/api/entity/Account.kt 85.48% <ø> (ø)
...otlin/social/bigbone/api/entity/data/Visibility.kt 100.00% <100.00%> (ø)
.../kotlin/social/bigbone/api/method/StatusMethods.kt 75.25% <100.00%> (ø)
...kotlin/social/bigbone/api/method/AccountMethods.kt 87.41% <81.42%> (+12.10%) ⬆️
.../main/kotlin/social/bigbone/rx/RxAccountMethods.kt 0.00% <0.00%> (ø)
...lin/social/bigbone/api/entity/CredentialAccount.kt 7.40% <7.40%> (ø)

@PattaFeuFeu PattaFeuFeu mentioned this pull request Dec 28, 2023
8 tasks
@PattaFeuFeu PattaFeuFeu force-pushed the enhancement/405-accounts-api branch from 4a8c534 to 821ac3b Compare December 28, 2023 20:31
@PattaFeuFeu PattaFeuFeu marked this pull request as ready for review December 28, 2023 20:32
@PattaFeuFeu PattaFeuFeu removed the blocked Blocked by another issue or PR label Dec 28, 2023
@PattaFeuFeu PattaFeuFeu added the breaking Incompatible with previous versions label Dec 28, 2023
Copy link
Owner

@andregasser andregasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Thank you :-)

@PattaFeuFeu PattaFeuFeu merged commit 198690f into master Dec 30, 2023
4 of 5 checks passed
@PattaFeuFeu PattaFeuFeu deleted the enhancement/405-accounts-api branch December 30, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Incompatible with previous versions documentation Improvements or additions to documentation or sample code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants