-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully implement partially implemented AccountMethods #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PattaFeuFeu
added
documentation
Improvements or additions to documentation or sample code
enhancement
New feature or request
labels
Dec 28, 2023
PattaFeuFeu
changed the title
Enhancement/405 accounts api
Fully implement partially implemented AccountMethods
Dec 28, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #411 +/- ##
============================================
- Coverage 49.84% 49.25% -0.60%
- Complexity 683 714 +31
============================================
Files 168 169 +1
Lines 4570 4769 +199
Branches 284 312 +28
============================================
+ Hits 2278 2349 +71
- Misses 2037 2157 +120
- Partials 255 263 +8
|
8 tasks
PattaFeuFeu
force-pushed
the
enhancement/405-accounts-api
branch
from
December 28, 2023 20:31
4a8c534
to
821ac3b
Compare
andregasser
reviewed
Dec 30, 2023
andregasser
reviewed
Dec 30, 2023
bigbone-rx/src/main/kotlin/social/bigbone/rx/RxAccountMethods.kt
Outdated
Show resolved
Hide resolved
andregasser
reviewed
Dec 30, 2023
andregasser
approved these changes
Dec 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! Thank you :-)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
Incompatible with previous versions
documentation
Improvements or additions to documentation or sample code
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part 1 for #405 and implements missing properties and entity parameters. No new methods will be added in this PR—that’ll be the task for a follow-up PR.
Type of Change
Breaking Changes
AccountMethods#verifyCredentials
now returnsCredentialAccount
instead ofAccount
AccountMethods#updateCredentials
now returnsCredentialAccount
instead ofAccount
AccountMethods#updateCredentials
got a few new parameters. As none of them are optional, this will break existing calls, but they can easily be added.AccountMethods#getStatuses
gained two now parametersexcludeReblogs
andfilterByTaggedWith
. Both are optional, like many existing parameters, but they are intertwined with other parameters. So if you use Java, or used Kotlin without named parameters here, your calls will likely or may return wrong results if you supply a Boolean to the wrong field.How Has This Been Tested?
New unit tests and updates for existing unit tests
Mandatory Checklist
gradle check
and there were no errors reported