Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set default part to None #6

Merged
merged 3 commits into from
Mar 11, 2021
Merged

set default part to None #6

merged 3 commits into from
Mar 11, 2021

Conversation

wsipak
Copy link
Contributor

@wsipak wsipak commented Mar 5, 2021

Changes:

  1. FPGA part name can now be provided as --part option. If no part name is provided, None is used.
  2. The docs are updated accordingly

@wsipak wsipak changed the title Default part none set default part to None Mar 5, 2021
@wsipak wsipak force-pushed the default_part_none branch from 9e185bc to 1424443 Compare March 9, 2021 16:16
@wsipak wsipak force-pushed the default_part_none branch from 1424443 to 4e9436f Compare March 9, 2021 18:39
tgorochowik
tgorochowik approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@tgorochowik tgorochowik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wsipak wsipak force-pushed the default_part_none branch from 4a48577 to 8b5fc06 Compare March 11, 2021 10:45
@tgorochowik tgorochowik merged commit 68caca5 into master Mar 11, 2021
@tgorochowik tgorochowik deleted the default_part_none branch March 11, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgorochowik tgorochowik tgorochowik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wsipak @tgorochowik