Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for simple untyped property arguments #24

Closed
wants to merge 3 commits into from
Closed

Add support for simple untyped property arguments #24

wants to merge 3 commits into from

Conversation

RRozak
Copy link
Member

@RRozak RRozak commented Oct 12, 2022 •
edited
Loading

It adds support for untyped arguments in properties. It doesn't work when some operations are used on untyped argument, such as bit select.
The following rule currently doesn't work:

A type shall apply to all formal arguments whose identifiers both follow the type and precede the next type, if any, specified in the port list.

@RRozak RRozak requested a review from kbieganski October 13, 2022 13:39
@RRozak RRozak force-pushed the rrozak/property-untyped branch from c3dff82 to 5c84ba8 Compare October 14, 2022 09:16
@RRozak RRozak force-pushed the rrozak/property-substitution branch 2 times, most recently from a4eed9b to 4a72a90 Compare October 14, 2022 16:30
@RRozak RRozak force-pushed the rrozak/property-substitution branch 2 times, most recently from 015bfc1 to bc6964b Compare October 25, 2022 14:00
@RRozak
Add named properties handling
a729dd5 
Signed-off-by: Ryszard Rozak <[email protected]>
@RRozak RRozak force-pushed the rrozak/property-substitution branch from bc6964b to a729dd5 Compare October 25, 2022 15:02
@RRozak RRozak force-pushed the rrozak/property-untyped branch from 5c84ba8 to 736ede0 Compare October 25, 2022 15:14
@RRozak RRozak force-pushed the rrozak/property-substitution branch from af8e1e7 to dc0d75c Compare October 28, 2022 07:35
@RRozak
Copy link
Member Author

RRozak commented Oct 28, 2022

I included the changes to this PR: verilator#3667

@RRozak RRozak closed this Oct 28, 2022
@RRozak RRozak deleted the rrozak/property-untyped branch May 31, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbieganski kbieganski Awaiting requested review from kbieganski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RRozak