Avoid segfault when verilating NBAs inside fork-join #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbieganski
requested changes
Mar 20, 2023
kiryk
force-pushed
the
kiryk/quick-fix-astcawait-null-sentree
branch
from
c25bd60 to
d45bc2b
Compare
kbieganski
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MR contains a testcase that makes Verilator segfault and a fix for that.
The segfault occurs, because V3Delay collects all sentree pointers from AstCAwaits. Some of these sentrees are nullptrs, so Verilator segaults when it tries to deep copy them in V3Delayed.cpp:460.
The solution is to skip the nullptrs.